Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-510 - Fix caching of null values.

Browse Source 
We now no longer add empty byte[] as cache value but return null instead.

Original pull request: #201.
This commit is contained in:
Christoph Strobl
2016-06-14 14:42:31 +02:00
committed by Mark Paluch
parent 28b5d61029
commit 67106bc75a
2 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/test/java/org/springframework/data/redis/cache/RedisCacheTest.java vendored
View File

@@ -17,6 +17,7 @@
package org.springframework.data.redis.cache;
import static edu.umd.cs.mtc.TestFramework.*;
import static org.hamcrest.core.Is.*;
import static org.hamcrest.core.IsEqual.*;
import static org.hamcrest.core.IsInstanceOf.*;
import static org.hamcrest.core.IsNot.*;
@@ -281,6 +282,38 @@ public class RedisCacheTest extends AbstractNativeCacheTest<RedisTemplate> {
assertThat(wrapper.get(), equalTo(value));
}
/**
* @see DATAREDIS-510
*/
@Test
public void cachePutWithNullShouldNotAddStuffToRedis() {
Object key = getKey();
Object value = getValue();
cache.put(key, null);
assertThat(cache.get(key), is(nullValue()));
}
/**
* @see DATAREDIS-510
*/
@Test
public void cachePutWithNullShouldRemoveKeyIfExists() {
Object key = getKey();
Object value = getValue();
cache.put(key, value);
assertThat(cache.get(key).get(), is(equalTo(value)));
cache.put(key, null);
assertThat(cache.get(key), is(nullValue()));
}
/**
* @see DATAREDIS-443
* @see DATAREDIS-452