Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix misordered 'final static' modifiers.

Browse Source 
Per the Java Language Specification (Java 17; https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.3.1), 'static' should appear before 'final'.

This is also consistent with source code analysis tools, like Checkstyle, rules: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheck.html.

Original pull request: #2640
This commit is contained in:
Thach Le
2023-07-14 18:16:09 +07:00
committed by Mark Paluch
parent cdcc4483f8
commit 7caa46cb4b
10 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/java/org/springframework/data/redis/SettingsUtils.java
View File

@@ -34,7 +34,7 @@ import org.springframework.data.redis.connection.RedisStandaloneConfiguration;
*/
public abstract class SettingsUtils {
private final static Properties DEFAULTS = new Properties();
private static final Properties DEFAULTS = new Properties();
private static final Properties SETTINGS;
static {

2
src/test/java/org/springframework/data/redis/cache/LegacyRedisCacheTests.java vendored
View File

@@ -54,7 +54,7 @@ import org.springframework.data.redis.test.extension.parametrized.ParameterizedR
@MethodSource("testParams")
public class LegacyRedisCacheTests {
private final static String CACHE_NAME = "testCache";
private static final String CACHE_NAME = "testCache";
private ObjectFactory<Object> keyFactory;
private ObjectFactory<Object> valueFactory;
private RedisConnectionFactory connectionFactory;

2
src/test/java/org/springframework/data/redis/test/XstreamOxmSerializerSingleton.java
View File

@@ -25,7 +25,7 @@ import com.thoughtworks.xstream.security.AnyTypePermission;
*/
public final class XstreamOxmSerializerSingleton {
private final static XstreamOxmSerializerSingleton instance = new XstreamOxmSerializerSingleton();
private static final XstreamOxmSerializerSingleton instance = new XstreamOxmSerializerSingleton();
private final OxmSerializer serializer;

2
src/test/java/org/springframework/data/redis/test/extension/parametrized/MethodArgumentsProvider.java
View File

@@ -42,7 +42,7 @@ import org.springframework.data.redis.ConnectionFactoryTracker.Managed;
*/
class MethodArgumentsProvider implements ArgumentsProvider, AnnotationConsumer<MethodSource> {
private final static Namespace NAMESPACE = Namespace.create(MethodArgumentsProvider.class);
private static final Namespace NAMESPACE = Namespace.create(MethodArgumentsProvider.class);
private String[] methodNames = new String[0];
@Override