From 7dd8b8ed5d70974f4d8f1012d11dc29e679df56e Mon Sep 17 00:00:00 2001
From: Mark Paluch <mark.paluch@broadcom.com>
Date: Tue, 17 Sep 2024 14:20:47 +0200
Subject: [PATCH] Polishing.

Add missing Nullable annotations. Reorder methods.

See: #2996
Original pull request: #2997
---
 .../data/redis/core/BoundListOperations.java       |  2 ++
 .../collections/AbstractRedisCollection.java       | 14 +++++++-------
 .../redis/support/collections/DefaultRedisMap.java | 11 +++++------
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/main/java/org/springframework/data/redis/core/BoundListOperations.java b/src/main/java/org/springframework/data/redis/core/BoundListOperations.java
index 2e76833c3..02d4f5309 100644
--- a/src/main/java/org/springframework/data/redis/core/BoundListOperations.java
+++ b/src/main/java/org/springframework/data/redis/core/BoundListOperations.java
@@ -249,6 +249,7 @@ public interface BoundListOperations<K, V> extends BoundKeyOperations<K> {
 	 * @since 2.4
 	 * @see <a href="https://redis.io/commands/lpos">Redis Documentation: LPOS</a>
 	 */
+	@Nullable
 	Long indexOf(V value);
 
 	/**
@@ -260,6 +261,7 @@ public interface BoundListOperations<K, V> extends BoundKeyOperations<K> {
 	 * @since 2.4
 	 * @see <a href="https://redis.io/commands/lpos">Redis Documentation: LPOS</a>
 	 */
+	@Nullable
 	Long lastIndexOf(V value);
 
 	/**
diff --git a/src/main/java/org/springframework/data/redis/support/collections/AbstractRedisCollection.java b/src/main/java/org/springframework/data/redis/support/collections/AbstractRedisCollection.java
index 842905a30..7f0a26f92 100644
--- a/src/main/java/org/springframework/data/redis/support/collections/AbstractRedisCollection.java
+++ b/src/main/java/org/springframework/data/redis/support/collections/AbstractRedisCollection.java
@@ -131,13 +131,6 @@ public abstract class AbstractRedisCollection<E> extends AbstractCollection<E> i
 		key = newKey;
 	}
 
-	protected void checkResult(@Nullable Object obj) {
-
-		if (obj == null) {
-			throw new IllegalStateException("Cannot read collection with Redis connection in pipeline/multi-exec mode");
-		}
-	}
-
 	@Override
 	public boolean equals(@Nullable Object o) {
 
@@ -168,4 +161,11 @@ public abstract class AbstractRedisCollection<E> extends AbstractCollection<E> i
 	public String toString() {
 		return "%s for key: %s".formatted(getClass().getSimpleName(), getKey());
 	}
+
+	protected void checkResult(@Nullable Object obj) {
+
+		if (obj == null) {
+			throw new IllegalStateException("Cannot read collection with Redis connection in pipeline/multi-exec mode");
+		}
+	}
 }
diff --git a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisMap.java b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisMap.java
index d5cb4659e..93fd9cbed 100644
--- a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisMap.java
+++ b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisMap.java
@@ -187,7 +187,6 @@ public class DefaultRedisMap<K, V> implements RedisMap<K, V> {
 
 	@Override
 	public String toString() {
-
 		return "RedisStore for key:" + getKey();
 	}
 
@@ -317,17 +316,17 @@ public class DefaultRedisMap<K, V> implements RedisMap<K, V> {
 		return hashOps.getType();
 	}
 
+	@Override
+	public Cursor<java.util.Map.Entry<K, V>> scan() {
+		return scan(ScanOptions.NONE);
+	}
+
 	private void checkResult(@Nullable Object obj) {
 		if (obj == null) {
 			throw new IllegalStateException("Cannot read collection with Redis connection in pipeline/multi-exec mode");
 		}
 	}
 
-	@Override
-	public Cursor<java.util.Map.Entry<K, V>> scan() {
-		return scan(ScanOptions.NONE);
-	}
-
 	/**
 	 * @since 1.4
 	 * @param options