Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-1095 - Use Flux.usingWhen(…) in DefaultReactiveScriptExecutor.execute(…).

Browse Source 
We now consistently use Flux.usingWhen(…) to obtain and release Redis connections without blocking the calling thread.

Original Pull Request: #509
This commit is contained in:
Mark Paluch
2020-02-05 15:12:19 +01:00
committed by Christoph Strobl
parent b3d54a3684
commit 87bbee4310
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/java/org/springframework/data/redis/core/script/DefaultReactiveScriptExecutorUnitTests.java
View File

@@ -18,6 +18,7 @@ package org.springframework.data.redis.core.script;
import static org.mockito.Mockito.*;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;
import java.nio.ByteBuffer;
@@ -37,6 +38,8 @@ import org.springframework.data.redis.connection.ReturnType;
import org.springframework.data.redis.serializer.RedisSerializationContext;
/**
* Unit tests for {@link DefaultReactiveScriptExecutor}.
*
* @author Mark Paluch
* @author Christoph Strobl
*/
@@ -56,6 +59,7 @@ public class DefaultReactiveScriptExecutorUnitTests {
when(connectionFactoryMock.getReactiveConnection()).thenReturn(connectionMock);
when(connectionMock.scriptingCommands()).thenReturn(scriptingCommandsMock);
when(connectionMock.closeLater()).thenReturn(Mono.empty());
executor = new DefaultReactiveScriptExecutor<>(connectionFactoryMock, RedisSerializationContext.string());
}
@@ -108,7 +112,8 @@ public class DefaultReactiveScriptExecutorUnitTests {
StepVerifier.create(execute).expectNext("FOO").verifyComplete();
verify(connectionMock).close();
verify(connectionMock).closeLater();
verify(connectionMock, never()).close();
}
@Test // DATAREDIS-683
@@ -119,7 +124,8 @@ public class DefaultReactiveScriptExecutorUnitTests {
StepVerifier.create(executor.execute(SCRIPT)).expectError().verify();
verify(connectionMock).close();
verify(connectionMock).closeLater();
verify(connectionMock, never()).close();
}
@Test // DATAREDIS-683