Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-698 - Polishing.

Browse Source 
Eagerly initialize known commands. Preallocate Jedis response builder. Replace list concatenation with array copy. Reject null arguments in execute(). Remove inversion through collections with direct byte array creation. Reorder arguments in signatures, visibility modifiers, Javadoc.

Original pull request: #283.
This commit is contained in:
Mark Paluch
2017-10-06 13:52:45 +02:00
parent f6a17fb268
commit 8adea79e67
9 changed files with 136 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/java/org/springframework/data/redis/connection/DefaultStringRedisConnectionTests.java
View File

@@ -18,16 +18,7 @@ package org.springframework.data.redis.connection;
import static org.junit.Assert.*;
import static org.mockito.Mockito.*;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
import java.util.*;
import java.util.concurrent.TimeUnit;
import org.junit.Before;
@@ -1702,7 +1693,7 @@ public class DefaultStringRedisConnectionTests {
@Test
public void testExecute() {
doReturn("foo").when(nativeConnection).execute("something", (byte[][]) null);
doReturn("foo").when(nativeConnection).execute("something", new byte[0][]);
actual.add(connection.execute("something"));
verifyResults(Arrays.asList(new Object[] { "foo" }));
}