Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix misordered 'final static' modifiers.

Browse Source 
Per the Java Language Specification (Java 17; https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.3.1), 'static' should appear before 'final'.

This is also consistent with source code analysis tools, like Checkstyle, rules: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheck.html.

Original pull request: #2640
This commit is contained in:
Thach Le
2023-07-14 18:16:09 +07:00
committed by Mark Paluch
parent b8a9d5fa0a
commit 95d5b82ac6
10 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/springframework/data/redis/connection/ReactiveRedisConnection.java
View File

@@ -417,7 +417,7 @@ public interface ReactiveRedisConnection extends Closeable {
*/
class AbsentByteBufferResponse<I> extends ByteBufferResponse<I> {
private final static ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.wrap(new byte[0]);
private static final ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.wrap(new byte[0]);
public AbsentByteBufferResponse(I input) {
super(input, EMPTY_BYTE_BUFFER);

2
src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java
View File

@@ -92,7 +92,7 @@ import org.springframework.util.ObjectUtils;
public class JedisConnectionFactory
implements RedisConnectionFactory, InitializingBean, DisposableBean, SmartLifecycle {
private final static Log log = LogFactory.getLog(JedisConnectionFactory.class);
private static final Log log = LogFactory.getLog(JedisConnectionFactory.class);
private static final ExceptionTranslationStrategy EXCEPTION_TRANSLATION = new PassThroughExceptionTranslationStrategy(
JedisExceptionConverter.INSTANCE);

2
src/main/java/org/springframework/data/redis/connection/lettuce/LettucePoolingConnectionProvider.java
View File

@@ -60,7 +60,7 @@ import org.springframework.util.Assert;
*/
class LettucePoolingConnectionProvider implements LettuceConnectionProvider, RedisClientProvider, DisposableBean {
private final static Log log = LogFactory.getLog(LettucePoolingConnectionProvider.class);
private static final Log log = LogFactory.getLog(LettucePoolingConnectionProvider.class);
private final LettuceConnectionProvider connectionProvider;
private final GenericObjectPoolConfig poolConfig;

2
src/main/java/org/springframework/data/redis/core/RedisCommand.java
View File

@@ -222,7 +222,7 @@ public enum RedisCommand {
private int minArgs = -1;
private int maxArgs = -1;
private final static Map<String, RedisCommand> commandLookup;
private static final Map<String, RedisCommand> commandLookup;
static {
commandLookup = buildCommandLookupTable();

4
src/main/java/org/springframework/data/redis/core/StreamObjectMapper.java
View File

@@ -47,8 +47,8 @@ import org.springframework.util.Assert;
*/
class StreamObjectMapper {
private final static RedisCustomConversions customConversions = new RedisCustomConversions();
private final static ConversionService conversionService;
private static final RedisCustomConversions customConversions = new RedisCustomConversions();
private static final ConversionService conversionService;
private final HashMapper<Object, Object, Object> mapper;
private final @Nullable HashMapper<Object, Object, Object> objectHashMapper;

4
src/main/java/org/springframework/data/redis/serializer/RedisSerializerToSerializationPairAdapter.java
View File

@@ -30,10 +30,10 @@ import org.springframework.util.Assert;
*/
class RedisSerializerToSerializationPairAdapter<T> implements SerializationPair<T> {
private final static RedisSerializerToSerializationPairAdapter<?> BYTE_BUFFER = new RedisSerializerToSerializationPairAdapter<>(
private static final RedisSerializerToSerializationPairAdapter<?> BYTE_BUFFER = new RedisSerializerToSerializationPairAdapter<>(
null);
private final static RedisSerializerToSerializationPairAdapter<byte[]> BYTE_ARRAY = new RedisSerializerToSerializationPairAdapter<>(
private static final RedisSerializerToSerializationPairAdapter<byte[]> BYTE_ARRAY = new RedisSerializerToSerializationPairAdapter<>(
RedisSerializer.byteArray());
private final DefaultSerializationPair pair;