diff --git a/src/main/java/org/springframework/data/redis/connection/RedisZSetCommands.java b/src/main/java/org/springframework/data/redis/connection/RedisZSetCommands.java index 426664376..2c4f4bb14 100644 --- a/src/main/java/org/springframework/data/redis/connection/RedisZSetCommands.java +++ b/src/main/java/org/springframework/data/redis/connection/RedisZSetCommands.java @@ -313,7 +313,7 @@ public interface RedisZSetCommands { * @return {@literal true} if no flags set. */ public boolean isEmpty() { - return !flags.isEmpty(); + return flags.isEmpty(); } @Override diff --git a/src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java b/src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java index 7eb55ec1f..ef746d039 100644 --- a/src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java +++ b/src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java @@ -618,7 +618,7 @@ abstract class JedisConverters extends Converters { */ static ZAddParams toZAddParams(ZAddArgs source) { - if (!source.isEmpty()) { + if (source.isEmpty()) { return new ZAddParams(); } diff --git a/src/main/java/org/springframework/data/redis/connection/lettuce/LettuceZSetCommands.java b/src/main/java/org/springframework/data/redis/connection/lettuce/LettuceZSetCommands.java index 9f7adcb62..488d91f7f 100644 --- a/src/main/java/org/springframework/data/redis/connection/lettuce/LettuceZSetCommands.java +++ b/src/main/java/org/springframework/data/redis/connection/lettuce/LettuceZSetCommands.java @@ -754,7 +754,7 @@ class LettuceZSetCommands implements RedisZSetCommands { io.lettuce.core.ZAddArgs target = new io.lettuce.core.ZAddArgs(); - if (!source.isEmpty()) { + if (source.isEmpty()) { return target; } diff --git a/src/test/java/org/springframework/data/redis/connection/RedisZSetCommandsUnitTests.java b/src/test/java/org/springframework/data/redis/connection/RedisZSetCommandsUnitTests.java new file mode 100644 index 000000000..9c7913a9b --- /dev/null +++ b/src/test/java/org/springframework/data/redis/connection/RedisZSetCommandsUnitTests.java @@ -0,0 +1,36 @@ +/* + * Copyright 2023 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.springframework.data.redis.connection; + +import static org.assertj.core.api.Assertions.*; + +import org.junit.jupiter.api.Test; +import org.springframework.data.redis.connection.RedisZSetCommands.ZAddArgs; + +/** + * Unit tests for {@link RedisZSetCommands}. + * + * @author Mark Paluch + */ +class RedisZSetCommandsUnitTests { + + @Test // GH-2588 + void zAddArgsShouldReportEmpty() { + + assertThat(ZAddArgs.empty().isEmpty()).isTrue(); + assertThat(ZAddArgs.ifExists().isEmpty()).isFalse(); + } +}