diff --git a/src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java b/src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java index af1076622..51862913b 100644 --- a/src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java +++ b/src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java @@ -425,9 +425,9 @@ public class JedisConnectionFactory implements InitializingBean, DisposableBean, int redirects = clusterConfig.getMaxRedirects() != null ? clusterConfig.getMaxRedirects() : 5; return new JedisCluster(hostAndPort, getConnectTimeout(), getReadTimeout(), redirects, getPassword(), - clientConfiguration.getClientName().orElse(null), poolConfig, isUseSsl(), - clientConfiguration.getSslSocketFactory().orElse(null), clientConfiguration.getSslParameters().orElse(null), - clientConfiguration.getHostnameVerifier().orElse(null), null); + getClientName(), poolConfig, isUseSsl(), clientConfiguration.getSslSocketFactory().orElse(null), + clientConfiguration.getSslParameters().orElse(null), clientConfiguration.getHostnameVerifier().orElse(null), + null); } /* @@ -473,9 +473,8 @@ public class JedisConnectionFactory implements InitializingBean, DisposableBean, } Jedis jedis = fetchJedisConnector(); - String clientName = clientConfiguration.getClientName().orElse(null); - JedisConnection connection = (getUsePool() ? new JedisConnection(jedis, pool, getDatabase(), clientName) - : new JedisConnection(jedis, null, getDatabase(), clientName)); + JedisConnection connection = (getUsePool() ? new JedisConnection(jedis, pool, getDatabase(), getClientName()) + : new JedisConnection(jedis, null, getDatabase(), getClientName())); connection.setConvertPipelineAndTxResults(convertPipelineAndTxResults); return postProcessConnection(connection); } @@ -549,6 +548,7 @@ public class JedisConnectionFactory implements InitializingBean, DisposableBean, * * @return password for authentication. */ + @Nullable public String getPassword() { return getRedisPassword().map(String::new).orElse(null); } diff --git a/src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactoryUnitTests.java b/src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactoryUnitTests.java index 139eb96e1..38ed91495 100644 --- a/src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactoryUnitTests.java +++ b/src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactoryUnitTests.java @@ -291,7 +291,7 @@ public class JedisConnectionFactoryUnitTests { assertThat(connectionFactory.getClusterConfiguration()).isSameAs(configuration); } - @Test // DATAREDIS-975 + @Test // DATAREDIS-974 public void shouldApplySslConfigWhenCreatingClusterClient() throws NoSuchAlgorithmException { SSLParameters sslParameters = new SSLParameters();