Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Introduce factory methods on RedisSet for easier construction of RediSet. Add javadoc.
Revise clear method to perform a DEL command instead of empty set intersection.

See #2037
Original Pull Request: #2105
This commit is contained in:
Mark Paluch
2021-06-29 15:37:33 +02:00
committed by Christoph Strobl
parent 90095d1c89
commit b6820f0f61
4 changed files with 109 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java
View File

@@ -1587,6 +1587,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSAdd() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sMembers("myset"));
@@ -1595,6 +1596,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSAddMultiple() {
actual.add(connection.sAdd("myset", "foo", "bar"));
actual.add(connection.sAdd("myset", "baz"));
actual.add(connection.sMembers("myset"));
@@ -1603,6 +1605,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSCard() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sCard("myset"));
@@ -1611,6 +1614,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSDiff() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sAdd("otherset", "bar"));
@@ -1620,6 +1624,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSDiffStore() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sAdd("otherset", "bar"));
@@ -1630,6 +1635,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSInter() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sAdd("otherset", "bar"));
@@ -1649,6 +1655,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSIsMember() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sIsMember("myset", "foo"));
@@ -1659,6 +1666,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test // GH-2037
@EnabledOnCommand("SMISMEMBER")
void testSMIsMember() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sMIsMember("myset", "foo", "bar", "baz"));
@@ -1667,6 +1675,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSMove() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sAdd("otherset", "bar"));
@@ -1676,6 +1685,7 @@ public abstract class AbstractConnectionIntegrationTests {
@Test
void testSPop() {
actual.add(connection.sAdd("myset", "foo"));
actual.add(connection.sAdd("myset", "bar"));
actual.add(connection.sPop("myset"));

1
src/test/java/org/springframework/data/redis/support/collections/AbstractRedisSetIntegrationTests.java
View File

@@ -72,6 +72,7 @@ public abstract class AbstractRedisSetIntegrationTests<T> extends AbstractRedisC
@ParameterizedRedisTest // GH-2037
@EnabledOnCommand("SMISMEMBER")
void testContainsAll() {
T t1 = getT();
T t2 = getT();
T t3 = getT();