From bf7a1466417b81e0d80461f5beb3bf9537c14823 Mon Sep 17 00:00:00 2001 From: Costin Leau Date: Tue, 2 Nov 2010 20:39:15 +0200 Subject: [PATCH] + wire to Spring DAO exception translation --- .../redis/CannotGetRedisConnectionException.java | 4 +--- .../core/jedis/JedisPersistenceExceptionTranslator.java | 8 ++++++-- .../core/jredis/JRedisPersistenceExceptionTranslator.java | 3 +-- .../support/RedisPersistenceExceptionTranslator.java | 1 - 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/CannotGetRedisConnectionException.java b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/CannotGetRedisConnectionException.java index 91c5fa88a..45cd5090f 100644 --- a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/CannotGetRedisConnectionException.java +++ b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/CannotGetRedisConnectionException.java @@ -23,8 +23,7 @@ import org.springframework.dao.DataAccessResourceFailureException; * * @author Mark Pollack */ -public class CannotGetRedisConnectionException extends - DataAccessResourceFailureException { +public class CannotGetRedisConnectionException extends DataAccessResourceFailureException { public CannotGetRedisConnectionException(String msg) { super(msg); @@ -33,5 +32,4 @@ public class CannotGetRedisConnectionException extends public CannotGetRedisConnectionException(String msg, Throwable cause) { super(msg, cause); } - } diff --git a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jedis/JedisPersistenceExceptionTranslator.java b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jedis/JedisPersistenceExceptionTranslator.java index bf71e4de8..42e2043d7 100644 --- a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jedis/JedisPersistenceExceptionTranslator.java +++ b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jedis/JedisPersistenceExceptionTranslator.java @@ -17,6 +17,7 @@ package org.springframework.datastore.redis.core.jedis; import org.springframework.dao.DataAccessException; import org.springframework.dao.InvalidDataAccessApiUsageException; +import org.springframework.dao.support.PersistenceExceptionTranslator; import org.springframework.datastore.redis.support.RedisPersistenceExceptionTranslator; /** @@ -25,11 +26,14 @@ import org.springframework.datastore.redis.support.RedisPersistenceExceptionTran * @author Mark Pollack * */ -public class JedisPersistenceExceptionTranslator implements - RedisPersistenceExceptionTranslator { +public class JedisPersistenceExceptionTranslator implements RedisPersistenceExceptionTranslator, + PersistenceExceptionTranslator { public DataAccessException translateException(Exception ex) { return new InvalidDataAccessApiUsageException(ex.getMessage(), ex); } + public DataAccessException translateExceptionIfPossible(RuntimeException ex) { + return new InvalidDataAccessApiUsageException(ex.getMessage(), ex); + } } diff --git a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jredis/JRedisPersistenceExceptionTranslator.java b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jredis/JRedisPersistenceExceptionTranslator.java index 4e4b61e6f..a626614b2 100644 --- a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jredis/JRedisPersistenceExceptionTranslator.java +++ b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/core/jredis/JRedisPersistenceExceptionTranslator.java @@ -19,8 +19,7 @@ import org.springframework.dao.DataAccessException; import org.springframework.dao.InvalidDataAccessApiUsageException; import org.springframework.datastore.redis.support.RedisPersistenceExceptionTranslator; -public class JRedisPersistenceExceptionTranslator implements - RedisPersistenceExceptionTranslator { +public class JRedisPersistenceExceptionTranslator implements RedisPersistenceExceptionTranslator { public DataAccessException translateException(Exception ex) { return new InvalidDataAccessApiUsageException(ex.getMessage(), ex); diff --git a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/support/RedisPersistenceExceptionTranslator.java b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/support/RedisPersistenceExceptionTranslator.java index cb2fad853..41a9a81d9 100644 --- a/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/support/RedisPersistenceExceptionTranslator.java +++ b/spring-datastore-redis/src/main/java/org/springframework/datastore/redis/support/RedisPersistenceExceptionTranslator.java @@ -27,7 +27,6 @@ import org.springframework.dao.DataAccessException; */ public interface RedisPersistenceExceptionTranslator { - //NOTE some client libraries throw checked exceptions. DataAccessException translateException(Exception ex); }