Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve atomicity in DefaultRedisCacheWriter.doLock().

Browse Source 
Closes #1686
Original pull request: #2879
This commit is contained in:
Chan Young
2024-03-23 20:59:22 +09:00
committed by Mark Paluch
parent 7fad17a1de
commit c980407f7d
2 changed files with 48 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/springframework/data/redis/cache/DefaultRedisCacheWriter.java vendored
View File

@@ -57,6 +57,7 @@ import org.springframework.util.ObjectUtils;
* @author Mark Paluch
* @author André Prata
* @author John Blum
* @author ChanYoung Joung
* @since 2.0
*/
class DefaultRedisCacheWriter implements RedisCacheWriter {
@@ -319,12 +320,15 @@ class DefaultRedisCacheWriter implements RedisCacheWriter {
}
@Nullable
private Boolean doLock(String name, Object contextualKey, @Nullable Object contextualValue,
RedisConnection connection) {
protected Boolean doLock(String name, Object contextualKey, @Nullable Object contextualValue,
RedisConnection connection) {
Expiration expiration = Expiration.from(this.lockTtl.getTimeToLive(contextualKey, contextualValue));
return connection.stringCommands().set(createCacheLockKey(name), new byte[0], expiration, SetOption.SET_IF_ABSENT);
while (!ObjectUtils.nullSafeEquals(connection.stringCommands().set(createCacheLockKey(name), new byte[0], expiration, SetOption.SET_IF_ABSENT),true)) {
checkAndPotentiallyWaitUntilUnlocked(name, connection);
}
return true;
}
/**