From e1a3b3100e07e51e1174ffc5472c73a46dbacfb3 Mon Sep 17 00:00:00 2001 From: Costin Leau Date: Wed, 23 May 2012 18:05:49 +0300 Subject: [PATCH] fix connection.setBit() DATAREDIS-89 --- .../data/redis/connection/jedis/JedisUtils.java | 4 ++-- .../connection/AbstractConnectionIntegrationTests.java | 9 +++++++++ .../jredis/JRedisConnectionIntegrationTests.java | 7 +++++-- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/springframework/data/redis/connection/jedis/JedisUtils.java b/src/main/java/org/springframework/data/redis/connection/jedis/JedisUtils.java index 7a107cd7e..43878dcd6 100644 --- a/src/main/java/org/springframework/data/redis/connection/jedis/JedisUtils.java +++ b/src/main/java/org/springframework/data/redis/connection/jedis/JedisUtils.java @@ -58,8 +58,8 @@ public abstract class JedisUtils { private static final String OK_CODE = "OK"; private static final String OK_MULTI_CODE = "+OK"; - private static final byte[] ONE = new byte[] { 1 }; - private static final byte[] ZERO = new byte[] { 0 }; + private static final byte[] ONE = new byte[] { '1' }; + private static final byte[] ZERO = new byte[] { '0' }; /** * Converts the given, native Jedis exception to Spring's DAO hierarchy. diff --git a/src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java b/src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java index 216be63be..4b4d3276f 100644 --- a/src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java +++ b/src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java @@ -116,6 +116,15 @@ public abstract class AbstractConnectionIntegrationTests { assertEquals("PONG", connection.ping()); } + @Test + public void testBitSet() throws Exception { + String key = "bitset-test"; + connection.setBit(key, 0, false); + connection.setBit(key, 1, true); + assertTrue(!connection.getBit(key, 0)); + assertTrue(connection.getBit(key, 1)); + } + @Test public void testInfo() throws Exception { Properties info = connection.info(); diff --git a/src/test/java/org/springframework/data/redis/connection/jredis/JRedisConnectionIntegrationTests.java b/src/test/java/org/springframework/data/redis/connection/jredis/JRedisConnectionIntegrationTests.java index 6ddc7df89..c38a6134c 100644 --- a/src/test/java/org/springframework/data/redis/connection/jredis/JRedisConnectionIntegrationTests.java +++ b/src/test/java/org/springframework/data/redis/connection/jredis/JRedisConnectionIntegrationTests.java @@ -22,7 +22,6 @@ import org.junit.Test; import org.springframework.data.redis.SettingsUtils; import org.springframework.data.redis.connection.AbstractConnectionIntegrationTests; import org.springframework.data.redis.connection.RedisConnectionFactory; -import org.springframework.data.redis.connection.jredis.JredisConnectionFactory; public class JRedisConnectionIntegrationTests extends AbstractConnectionIntegrationTests { @@ -86,6 +85,10 @@ public class JRedisConnectionIntegrationTests extends AbstractConnectionIntegrat @Ignore public void testPubSubWithNamedChannels() { - } + + @Ignore + public void testBitSet() throws Exception { + } + } \ No newline at end of file