From f92ed7632dcd76107e6b17f754a15d6d841746a7 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Wed, 15 Jul 2020 10:09:21 +0200 Subject: [PATCH] DATAREDIS-1091 - Polishing. Make fields final where possible. Update since tags. Original pull request: #517. --- .../data/redis/core/RedisKeyValueAdapter.java | 6 +++--- .../repository/configuration/EnableRedisRepositories.java | 4 ++-- .../data/redis/core/RedisKeyValueAdapterTests.java | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/springframework/data/redis/core/RedisKeyValueAdapter.java b/src/main/java/org/springframework/data/redis/core/RedisKeyValueAdapter.java index 720e75fee..4cac1d460 100644 --- a/src/main/java/org/springframework/data/redis/core/RedisKeyValueAdapter.java +++ b/src/main/java/org/springframework/data/redis/core/RedisKeyValueAdapter.java @@ -869,7 +869,7 @@ public class RedisKeyValueAdapter extends AbstractKeyValueAdapter * publishing {@link RedisKeyspaceEvent}. * * @author Christoph Strobl - * @since 2.3 + * @since 2.4 */ public enum ShadowCopy { @@ -900,8 +900,8 @@ public class RedisKeyValueAdapter extends AbstractKeyValueAdapter private final Object targetId; private final byte[] targetKey; - private Set fieldsToRemove = new LinkedHashSet<>(); - private Set indexesToUpdate = new LinkedHashSet<>(); + private final Set fieldsToRemove = new LinkedHashSet<>(); + private final Set indexesToUpdate = new LinkedHashSet<>(); RedisUpdateObject(byte[] targetKey, String keyspace, Object targetId) { diff --git a/src/main/java/org/springframework/data/redis/repository/configuration/EnableRedisRepositories.java b/src/main/java/org/springframework/data/redis/repository/configuration/EnableRedisRepositories.java index 66e9f94b4..eae924416 100644 --- a/src/main/java/org/springframework/data/redis/repository/configuration/EnableRedisRepositories.java +++ b/src/main/java/org/springframework/data/redis/repository/configuration/EnableRedisRepositories.java @@ -170,9 +170,9 @@ public @interface EnableRedisRepositories { /** * Configuration flag controlling storage of phantom keys (shadow copies) of expiring entities to read them later when * publishing {@link org.springframework.data.redis.core.RedisKeyspaceEvent keyspace events}. - * + * * @return - * @since 2.3 + * @since 2.4 */ ShadowCopy shadowCopy() default ShadowCopy.DEFAULT; diff --git a/src/test/java/org/springframework/data/redis/core/RedisKeyValueAdapterTests.java b/src/test/java/org/springframework/data/redis/core/RedisKeyValueAdapterTests.java index 819cfe03b..cf2e9df8b 100644 --- a/src/test/java/org/springframework/data/redis/core/RedisKeyValueAdapterTests.java +++ b/src/test/java/org/springframework/data/redis/core/RedisKeyValueAdapterTests.java @@ -58,6 +58,8 @@ import org.springframework.data.redis.core.index.Indexed; import org.springframework.data.redis.core.mapping.RedisMappingContext; /** + * Integration tests for {@link RedisKeyValueAdapter}. + * * @author Christoph Strobl * @author Mark Paluch */