Commit Graph

421 Commits

Author SHA1 Message Date
Mark Paluch
d3a0c34904 DATAREDIS-592 - Consider expiry timeout in synchronized RedisCache mode.
We now consider the element expiry when retrieving cache elements with a value loader. Previously, all cache elements that were cached using `@Cacheable(sync=true)` or used `RedisCache.get(Object, Callable)` directly were considered eternal without setting a TTL.

Original Pull Request: #234
2017-01-20 10:21:53 +01:00
Christoph Strobl
9b6ff3779c DATAREDIS-564 - Polishing.
Remove white spaces, update license header.
Add ticket reference to existing testcase.

Original Pull Request: #228
2017-01-13 10:29:55 +01:00
Mark Paluch
1fd9aadd70 DATAREDIS-564 - Delegate expire(…) to pExpire if timeout exceeds Integer.MAX_VALUE.
Remove pExpireAt workaround that can lead to NullPointerException if called within a transaction/pipeline. Calls to expire(…) with a timeout greater Integer.MAX_VALUE are delegated to pExpire converting seconds to milliseconds.

Related ticket: DATAREDIS-286.
Original Pull Request: #228
2017-01-13 10:29:44 +01:00
Mark Paluch
05809febb9 DATAREDIS-589 - Polishing.
Run expiry tests only when executing long-running tests. Guard RedisConnectionFactory against multiple initializations. Synchronize key expiry. Remove unused code. Extend years in license header.

Original pull request: #232.
2017-01-12 15:01:59 +01:00
Christoph Strobl
639b1e2b55 DATAREDIS-589 - Move secondary index cleanup to MappingExpirationListener.
We now no longer rely on ApplicationEvents captured in the RedisKeyValueAdapter for performing cleanup operations for expired keys, but do this along with the phantom key removal. This removes a flaw when initializing a non repository related KeyspaceEventListener publishing events that actually are unrelated to the Adapter.

Additionally upgraded test infrastructure to utilize Redis 3.2.6 with disabled protected-mode and enabled keyspace-events.

Original pull request: #232.
2017-01-12 14:52:59 +01:00
Mark Paluch
253c281205 DATAREDIS-532 - Enhance JavaDoc and convert links to Redis documentation.
Extend JavaDoc documentation for Command/Connection/Operation interfaces. Align method ordering in operation interfaces with connection/commands interfaces.
2017-01-12 14:52:59 +01:00
Mark Paluch
ceea66e17e DATAREDIS-563 - Migrate ticket references in test code to Spring Framework style.
Fix license headers by removing the dot after the year.
2017-01-12 14:52:53 +01:00
Oliver Gierke
f61bdfbcd6 DATAREDIS-583 - Adapt API in RedisRepositoryFactoryBean.
Related tickets: DATACMNS-891.
2016-12-15 16:24:34 +01:00
Mark Paluch
3788ad7235 DATAREDIS-552 - Polishing.
Apply client name to Sentinel and unpooled connections if set. Add ticket references to JavaDoc. Add tests. Fix existing JavaDoc letter casing and punctuation. Rearrange isClusterAware/isRedisSentinelAware methods.

Original pull request: #219.
2016-12-01 09:01:45 +01:00
Fu Jian
dbb3473d0d DATAREDIS-552 - Support client name configuration for JedisConnectionFactory.
Motivation:
JedisConnectionFactory should support setting clientName for Jedis connections
so to improve troubleshooting.

Result:
Easier to troubleshooting with connection name.

Original pull request: #219.
2016-12-01 09:01:45 +01:00
Mark Paluch
b172c237e4 DATAREDIS-525 - Polishing.
Enhance JavaDoc. Improve assertions. Reduce accepted collection-type boundary to Collection for commands that do not enforce a specific order. Add ByteUtil.getBytes(ByteBuffer) utility method. Reformat code. Extend documentation

Fix parameter ambiguity in LettuceConnection.watch().

Original pull request: #229.
2016-11-17 20:17:10 +01:00
Mark Paluch
62b1354e02 DATAREDIS-525 - Upgrade to lettuce 5.0.0.Beta1.
- Replace deprecated method usage by using newly introduced API.
- Improve converter names, remove unused code, fix generics.

Original pull request: #229.
2016-11-17 20:17:05 +01:00
Christoph Strobl
d257ae1074 DATAREDIS-525 - Add support for ReactiveRedisConnection & ReactiveRedisClusterConnection.
We introduced reactor based reactive connection support via ReactiveRedisConnection and ReactiveRedisClusterConnection.

A reactive connection can be obtained via the ConnectionFactory. This is currently only possible when using the Lettuce Redis driver.

Original pull request: #229.
2016-11-17 20:10:03 +01:00
Christoph Strobl
f6411b3811 DATAREDIS-567 - Remove Support for SRP and JRedis. 2016-11-07 15:34:12 +01:00
Mark Paluch
aa3c40780a DATAREDIS-528 - Polishing.
Extend date ranges in license headers. Add author tags. Update documentation.

Original pull request: #222.
2016-10-12 16:34:13 +02:00
Christoph Strobl
4be4ed0b28 DATAREDIS-528 - Upgrade to Lettuce 4.2.2.
We now support Lettuce 4.2.2.Final. Using Lettuce requires Java 8.

Original pull request: #222.
2016-10-12 15:45:38 +02:00
Mark Paluch
863e5b8d68 DATAREDIS-553 - Polishing.
Improve javadoc. Replace static method imports with qualified method calls. Refactor duplicate RedisCacheKey construction into own method. Fix formatting.

Original pull request: #221.
2016-10-12 15:07:13 +02:00
Mark Paluch
f26441d48d DATAREDIS-553 - Support caching null values via RedisCache using callable.
Store `NullValue` placeholders when null value caching is allowed. Remove cache values when null value caching is disabled and the value loader returns a `null` value.

Original pull request: #221.
2016-10-12 15:07:09 +02:00
Christoph Strobl
4c54bf972a DATAREDIS-553 - Support caching null values via RedisCache.
We now support caching `null` values in `RedisCache` by storing a dedicated `NullValue` reference as a placeholder. To enable this feature please set up `RedisCacheManager` accordingly and make sure the used `RedisSerializer` is capable of dealing the `NullValue` type.
Both the `JdkSerializationRedisSerializer` and the `GenericJackson2JsonRedisSerializer` support this out of the box.

Original pull request: #221.
2016-10-12 15:06:59 +02:00
Christoph Strobl
72d6df00c8 DATAREDIS-542 - Polishing.
Prevent putIfAbsent from prolonging expiration time of existing keys having same value.
Remove some trailing white spaces.

Original Pull Request: #224
2016-10-07 11:31:14 +02:00
Mark Paluch
ea598c2dad DATAREDIS-542 - Fix key expiration for RedisCache.putIfAbsent.
RedisCache now expires keys using putIfAbsent if the key was set. Previously, the key was only expired if the value was already present and the value matched the value stored inside of Redis.

Original Pull Request: #224
2016-10-07 11:30:50 +02:00
Mark Paluch
4c8f1674e4 DATAREDIS-533 - Polishing.
Remove empty lines after last inner class. Extract duplicate code in variable. Fix spelling. Update Reference Documentation. Remove merge leftovers.

Original pull request: #215.
2016-09-13 15:43:28 +02:00
Christoph Strobl
07d0b82100 DATAREDIS-533 - Add support for geo indexes.
We now allow usage of @GeoIndexed to mark GeoLocation or Point properties as candidates for secondary index creation. Non null values will be included in GEOADD command as follows:

    GEOADD keyspace:property-path point.x point.y entity-id

@GeoIndexed can be used on top level as well as on nested properties.

class Person {

	@Id String id;
	String firstname, lastname;
	Address hometown;
}

class Address {
	String city, street, housenumber;
	@GeoIndexed Point location;
}

The above allows us to derive geospatial queries from a given method using NEAR and WITHIN keywords like:

interface PersonRepository extends CrudRepository<Person, String> {

	List<Person> findByAddressLocationNear(Point point, Distance distance);

	List<Person> findByAddressLocationWithin(Circle circle);
}

Partial updates on the Point itself also trigger an index refresh operation. So it is possible to alter existing entities via:

template.save(new PartialUpdate<Person>("1", Person.class).set("address.location", new Point(17, 18));

Original pull request: #215.
2016-09-13 15:43:28 +02:00
Christoph Strobl
5d09272876 DATAREDIS-551 - Polishing.
Fix indentation.

Original Pull Request: #220
2016-09-13 10:10:23 +02:00
Mark Paluch
5aef8c3b0b DATAREDIS-551 - Fix pageable query execution when derived criteria is empty.
We now make sure to count records without using criteria when derived criteria is empty. This allows usage of declared query methods using `Pageable` without criteria like `findBy(Pageable page)`.

Original Pull Request: #220
2016-09-13 10:10:16 +02:00
Mark Paluch
a8462c597e DATAREDIS-547 - Polishing.
Return empty list if offset is greater than the available data set. Update supported keywords in reference docs.

Original pull request: #216.
2016-09-12 14:53:07 +02:00
Christoph Strobl
83ff5ec85b DATAREDIS-547 - Fix query execution when derived criteria is empty.
We now make sure to pipe finder queries without any criteria to the according find all method. This allows usage of `PagingAndSortingRepository.findAllBy(Pageable page)` as well as finders without any criteria like `findTop3By()`.

Original pull request: #216.
2016-09-12 14:52:51 +02:00
Christoph Strobl
58d23dea37 DATAREDIS-531 - Scan commands should use a dedicated bound connection.
SCAN, SSCAN, HSCAN and ZSCAN now reference a dedicated connection that is bound to the Cursor. This allows creation of multiple cursors for different threads without the risk of potentially sharing a single connection. As before the caller is responsible for closing the Cursor correctly after usage.

Original pull request: #218.
2016-09-05 11:23:40 +02:00
Mark Paluch
53c7f80676 DATAREDIS-548 - Release connection after command execution in read-only transactions.
We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful.

Previously, RedisConnection's were bound as transactional resource when used in the scope of a @Transactional(readOnly = true) method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer.

Original Pull Request: #214
2016-08-30 13:00:31 +02:00
Christoph Strobl
b47fc350e0 DATAREDIS-539 - Replace call to deprecated addCache in RedisCacheManager.
We now rely on getMissingCache and loadCaches for initialization instead of explicitly calling deprecated addCache method.

Original pull request: #212.
2016-08-22 10:51:58 +02:00
Christoph Strobl
eb210a4b8a DATAREDIS-506 - Polishing.
Make use of CollectionUtils and remove duplicate code paths.

Original Pull Request: #211
2016-07-26 15:48:21 +02:00
Mark Paluch
1a332c0f57 DATAREDIS-506 - Upgrade to Jedis 2.9.0.
We now support Jedis 2.9.0 with Redis Standalone SSL and Redis Cluster with passwords. The code is compatible with Jedis 2.8.0 when not using SSL or Redis Cluster with passwords.

Original Pull Request: #211
2016-07-26 15:48:03 +02:00
Christoph Strobl
f606d06b30 DATAREDIS-537 - Polishing.
Move duplicate code into single place and use ternary expressions where applicable.
Use static imports in tests where applicable.

Original Pull Request: #210
2016-07-25 14:46:51 +02:00
Mark Paluch
c7c9a8aab5 DATAREDIS-537 - Add support for Redis Cluster and SSL.
Support SSL, StartTLS and VerifyPeer flags.

Original Pull Request: #210
2016-07-25 14:13:25 +02:00
Mark Paluch
fd6e4d12ea DATAREDIS-523 - Polishing.
Allow reading of the TTL into primitive properties. Allow general numeric types for TTL properties. Extend date range in license headers. Extend JavaDoc.

Original pull request: #208.
2016-07-13 08:51:48 +02:00
Christoph Strobl
c4ddc9e125 DATAREDIS-523 - Read back TTL into property.
We now read back TTL value from Redis for explicitly @TimeToLive annotated properties.

Original pull request: #208.
2016-07-13 08:51:16 +02:00
Mark Paluch
e8a30a79a0 DATAREDIS-526 - Allow using ttl and pttl with TimeUnit on connection-level.
We now support ttl and pttl accepting a TimeUnit on connection level to return the TTL in the requested time unit. By performing the conversion inside the connection we return correct results for plain, pipelining and transaction execution. Add also JavaDoc and @Override to ttl/pttl methods.

Original pull request: #205.
2016-07-08 08:50:56 +02:00
oudb
e64f84b45a DATAREDIS-526 - Fix getExpire return value.
getExpire returns now negative values without time unit conversion in case of absent values or values without a TTL set.

CLA: 143520151016081625 (Duobiao Ou)
Original pull request: #205.
2016-07-08 08:50:30 +02:00
Christoph Strobl
f5a506cb8d DATAREDIS-530 - Fix PartialUpdate removing existing indexes.
We now make sure to leave existing indexes untouched when using PartialUpdate.
We also fixed a glitch, where index values have not been removed correctly when saving entities with null values, along the way.

Original pull request: #207.
2016-07-06 14:34:29 +02:00
Christoph Strobl
0d24b5a573 DATAREDIS-524 - Polishing.
Some formatting changes.

Original Pull Request: #204
2016-07-06 14:16:18 +02:00
Mark Paluch
ea33cd40e6 DATAREDIS-524 - Use password to connect Redis nodes using Sentinel.
LettuceConnectionFactory and DefaultLettucePool now use the configured password to authenticate with Redis. Authentication is applied when connecting to nodes that were obtained from Redis Sentinel.

Original Pull Request: #204
2016-07-06 14:16:08 +02:00
Mark Paluch
74a5652ff0 DATAREDIS-505 - Polishing.
Extend date range in license header. Retrieve connection and config for possible reconfiguration only if keyspaceNotificationsConfigParameter has a value.

Original pull request: #202.
2016-06-17 13:07:31 +02:00
Christoph Strobl
65c7b2c23e DATAREDIS-505 - Allow configuration of Redis Keyspace events config value.
We now allow setting the desired notify-keyspace-events server configuration via @EnableRedisRepsoitories. Use `null` or an empty String for not touching the server’s config. The default is `Ex`.

Original pull request: #202.
2016-06-17 13:07:20 +02:00
Mark Paluch
64456ea134 DATAREDIS-500 - Polishing.
Apply formatting rules. Use differing serializers in test.

Original pull request: #190.
2016-06-17 09:35:57 +02:00
Anqing Shao
73c8ce2009 DATAREDIS-500 - Use Hash Key and Hash Value serializers in RedisTemplate executePipelined(…).
RedisTemplate executePipelined(RedisCallback) uses now the Hash Key and Hash Value serializers to deserialize the response.

Original pull request: #190.
CLA: 174020160421053943 (Anqing Shao).
2016-06-17 09:35:57 +02:00
Christoph Strobl
67106bc75a DATAREDIS-510 - Fix caching of null values.
We now no longer add empty byte[] as cache value but return null instead.

Original pull request: #201.
2016-06-14 16:56:47 +02:00
Christoph Strobl
7af8fdf946 DATAREDIS-513 - Fix RedisServerCommands.time() failure when in pipeline mode.
We fixed a glitch in Jedis/Lettuce RedisConneciton TIME command when used in pipeline or transaction mode.

Original pull request: #199.
2016-06-02 09:33:19 +02:00
Christoph Strobl
2b51966768 DATAREDIS-514 - Unify geoRadius capitalization.
Unify capitalization of geoRadius to match other geo prefixed operations.

Original pull request: #200.
2016-05-27 09:36:38 +02:00
Mark Paluch
d88d992f6d DATAREDIS-471 - Polishing.
Update reference documentation. Enhance JavaDoc. Remove destroy of managed bean. Refactor property update of writePartialUpdate into own method. Remove trailing whitespaces in JavaDoc.

Original pull request: #191.
2016-05-25 16:36:46 +02:00
Christoph Strobl
76229c10a4 DATAREDIS-471 - Add support for partial updates.
We now allow partial update of domain types via PartialUpdate. The according expiration times and secondary index structures are updated accordingly.

In some cases it is not necessary to load and rewrite the entire entity just to set a new value within it. A session timestamp for last active time might be such a scenario where you just want to alter one property.
`PartialUpdate` allows to define `set`, `delete` actions on existing objects while taking care of updating potential expiration times of the entity itself as well as index structures.

.Sample Partial Update
====
[source,java]
----
PartialUpdate<Person> update = new PartialUpdate<Person>("e2c7dcee", Person.class)
  .set("firstname", "mat")                                                           <1>
  .set("address.city", "emond's field")                                              <2>
  .del("age");                                                                       <3>

template.update(update);

update = new PartialUpdate<Person>("e2c7dcee", Person.class)
  .set("address", new Address("caemlyn", "andor"))                                   <4>
  .set("attributes", singletonMap("eye-color", "grey"));                             <5>

template.update(update);

update = new PartialUpdate<Person>("e2c7dcee", Person.class)
  .refreshTtl(true);                                                                 <6>
  .set("expiration", 1000);

template.update(update);
----
<1> Set the simple property _firstname_ to _mat_
<2> Set the simple property _address.city_ to _emond's field_ without having to pass in the entire object. This does not work when a custom conversion is registered.
<3> Remove the property _age_.
<4> Set complex property _address_.
<5> Set a map/collection of values removes the previously existing map/collection and replaces the values with the given ones.
<6> Automatically update the server expiration time when altering time to live.
====

NOTE: Updating complex objects as well as map/collection structures requires further interaction with Redis to determine existing values which means that it might turn out that rewriting the entire entity might be faster.

Original pull request: #191.
2016-05-25 16:36:46 +02:00