From 13ed4baf45f97d8a579b2c9ec5a9e34018fb318a Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Tue, 23 Apr 2024 11:52:21 +0200 Subject: [PATCH] Polishing. Add author tags. See #1721 Original pull request #1722 --- .../springframework/data/jdbc/core/convert/JdbcConverter.java | 1 + .../data/jdbc/repository/query/JdbcQueryMethod.java | 1 + .../data/relational/core/mapping/DerivedSqlIdentifier.java | 1 + .../data/relational/core/sql/DefaultSqlIdentifier.java | 1 + 4 files changed, 4 insertions(+) diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcConverter.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcConverter.java index ae5b4aa2..a78bed13 100644 --- a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcConverter.java +++ b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcConverter.java @@ -34,6 +34,7 @@ import org.springframework.lang.Nullable; * versa. * * @author Jens Schauder + * @author Mark Paluch * @since 1.1 */ public interface JdbcConverter extends RelationalConverter { diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/JdbcQueryMethod.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/JdbcQueryMethod.java index 68c684f1..bc555566 100644 --- a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/JdbcQueryMethod.java +++ b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/JdbcQueryMethod.java @@ -50,6 +50,7 @@ import org.springframework.util.StringUtils; * @author Moises Cisneros * @author Hebert Coelho * @author Diego Krupitza + * @author Mark Paluch */ public class JdbcQueryMethod extends QueryMethod { diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/DerivedSqlIdentifier.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/DerivedSqlIdentifier.java index 7bf01c48..c0ecd3d4 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/DerivedSqlIdentifier.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/DerivedSqlIdentifier.java @@ -63,6 +63,7 @@ class DerivedSqlIdentifier implements SqlIdentifier { @Override public String toSql(IdentifierProcessing processing) { + // using a local copy of volatile this.sqlName to ensure thread safety. CachedSqlName sqlName = this.sqlName; if (sqlName == null || sqlName.processing != processing) { diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DefaultSqlIdentifier.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DefaultSqlIdentifier.java index c2f5916f..973bf2ad 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DefaultSqlIdentifier.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DefaultSqlIdentifier.java @@ -62,6 +62,7 @@ class DefaultSqlIdentifier implements SqlIdentifier { @Override public String toSql(IdentifierProcessing processing) { + // using a local copy of volatile this.sqlName to ensure thread safety. CachedSqlName sqlName = this.sqlName; if (sqlName == null || sqlName.processing != processing) {