Spring/spring-data-relational
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAJDBC-542 - Fixes access to Identifier parts by String.

Browse Source 
Enabled access to identifier parts by String arguments in order to make usage with MyBatis feasable.
Properly pass identifier information to MyBatis for insert statements.

Original pull request: #218.
This commit is contained in:
Jens Schauder
2020-05-12 15:43:02 +02:00
committed by Mark Paluch
parent ae70d9593c
commit 30a6fb5654
5 changed files with 98 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/IdentifierUnitTests.java
View File

@@ -22,8 +22,10 @@ import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.assertj.core.api.Assertions;
import org.assertj.core.api.SoftAssertions;
import org.junit.Test;
import org.springframework.data.relational.core.sql.IdentifierProcessing;
import org.springframework.data.relational.core.sql.SqlIdentifier;
@@ -111,4 +113,23 @@ public class IdentifierUnitTests {
assertThat(one).isEqualTo(two);
assertThat(one).isNotEqualTo(three);
}
@Test // DATAJDBC-542
public void identifierPartsCanBeAccessedByString() {
Map<SqlIdentifier, Object> idParts = new HashMap<>();
idParts.put(unquoted("aName"), "one");
idParts.put(quoted("Other"), "two");
Identifier id = Identifier.from(idParts);
Map<SqlIdentifier, Object> map = id.toMap();
SoftAssertions.assertSoftly(softly -> {
softly.assertThat(map.get("aName")).describedAs("aName").isEqualTo("one");
softly.assertThat(map.get("Other")).describedAs("Other").isEqualTo("two");
softly.assertThat(map.get("other")).describedAs("other").isNull();
softly.assertThat(map.get("OTHER")).describedAs("OTHER").isNull();
});
}
}

50
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/mybatis/MyBatisContextUnitTests.java Normal file
View File

@@ -0,0 +1,50 @@
/*
* Copyright 2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.jdbc.mybatis;
import java.util.HashMap;
import java.util.Map;
import org.assertj.core.api.SoftAssertions;
import org.junit.Test;
import org.springframework.data.jdbc.core.convert.Identifier;
import org.springframework.data.relational.core.sql.SqlIdentifier;
public class MyBatisContextUnitTests {
@Test // DATAJDBC-542
public void testGetReturnsValuesFromIdentifier() {
Map<SqlIdentifier, Object> map = new HashMap<>();
map.put(SqlIdentifier.quoted("one"), "oneValue");
map.put(SqlIdentifier.unquoted("two"), "twoValue");
map.put(SqlIdentifier.quoted("Three"), "threeValue");
map.put(SqlIdentifier.unquoted("Four"), "fourValue");
MyBatisContext context = new MyBatisContext(Identifier.from(map), null, null);
SoftAssertions.assertSoftly(softly -> {
softly.assertThat(context.get("one")).isEqualTo("oneValue");
softly.assertThat(context.get("two")).isEqualTo("twoValue");
softly.assertThat(context.get("Three")).isEqualTo("threeValue");
softly.assertThat(context.get("Four")).isEqualTo("fourValue");
softly.assertThat(context.get("four")).isNull();
softly.assertThat(context.get("five")).isNull();
});
}
}