From 6e715cb6b3c87c722901cd2cc791fa8511c111e6 Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Wed, 16 Oct 2019 14:32:17 +0200 Subject: [PATCH] DATAJDBC-427 - Polishing. Used isEqual assertions instead of directly calling equals. Code formatting. --- .../jdbc/core/mapping/AggregateReference.java | 1 - .../mapping/IdOnlyAggregateReferenceTest.java | 53 +++++++++++-------- 2 files changed, 30 insertions(+), 24 deletions(-) diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/mapping/AggregateReference.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/mapping/AggregateReference.java index 6acaabd9..d69c1250 100644 --- a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/mapping/AggregateReference.java +++ b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/mapping/AggregateReference.java @@ -61,5 +61,4 @@ public interface AggregateReference { return id; } } - } diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/IdOnlyAggregateReferenceTest.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/IdOnlyAggregateReferenceTest.java index 790b97cf..7ff7251e 100644 --- a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/IdOnlyAggregateReferenceTest.java +++ b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/IdOnlyAggregateReferenceTest.java @@ -11,30 +11,37 @@ import org.springframework.data.jdbc.core.mapping.AggregateReference.IdOnlyAggre * @author Myeonghyeon Lee */ public class IdOnlyAggregateReferenceTest { - @Test // DATAJDBC-427 - public void equals() { - AggregateReference reference1 = AggregateReference.to("1"); - AggregateReference reference2 = AggregateReference.to("1"); - assertThat(reference1.equals(reference2)).isTrue(); - assertThat(reference2.equals(reference1)).isTrue(); - } - @Test // DATAJDBC-427 - public void equalsFalse() { - AggregateReference reference1 = AggregateReference.to("1"); - AggregateReference reference2 = AggregateReference.to("2"); - assertThat(reference1.equals(reference2)).isFalse(); - assertThat(reference2.equals(reference1)).isFalse(); - } + @Test // DATAJDBC-427 + public void equals() { - @Test // DATAJDBC-427 - public void hashCodeTest() { - AggregateReference reference1 = AggregateReference.to("1"); - AggregateReference reference2 = AggregateReference.to("1"); - assertThat(reference1.hashCode()).isEqualTo(reference2.hashCode()); - } + AggregateReference reference1 = AggregateReference.to("1"); + AggregateReference reference2 = AggregateReference.to("1"); - private static class DummyEntity { - private String id; - } + assertThat(reference1).isEqualTo(reference2); + assertThat(reference2).isEqualTo(reference1); + } + + @Test // DATAJDBC-427 + public void equalsFalse() { + + AggregateReference reference1 = AggregateReference.to("1"); + AggregateReference reference2 = AggregateReference.to("2"); + + assertThat(reference1).isNotEqualTo(reference2); + assertThat(reference2).isNotEqualTo(reference1); + } + + @Test // DATAJDBC-427 + public void hashCodeTest() { + + AggregateReference reference1 = AggregateReference.to("1"); + AggregateReference reference2 = AggregateReference.to("1"); + + assertThat(reference1.hashCode()).isEqualTo(reference2.hashCode()); + } + + private static class DummyEntity { + private String id; + } }