From b7afc380e12d7923411a17e1d183bf64257015ac Mon Sep 17 00:00:00 2001 From: Diego Krupitza Date: Thu, 17 Feb 2022 16:26:06 +0100 Subject: [PATCH] `StringBuilder` can be replaced with String concatenation. In this case the usage of `StringBuilder` has no additional benefit, since it is not inside a loop where the JVM may have problems detecting String concatenation that can be optimized. The usage of "simple" String concatenation makes the code more readable and the code will be automatically optimised by the compiler. Original pull request #1173 --- .../springframework/data/relational/core/sql/AssignValue.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java index 3cbc44fc..5bd22259 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java @@ -72,7 +72,6 @@ public class AssignValue extends AbstractSegment implements Assignment { @Override public String toString() { - StringBuilder builder = new StringBuilder(); - return builder.append(this.column).append(" = ").append(this.value).toString(); + return this.column + " = " + this.value; } }