Polishing.
Deprecate original DialectResolver and JdbcArrayColumns as they've been in the wrong package and introduce replacements in the dialect package. Let deprecated types extend from their replacements to retain compatibility. Make instance holders final, fix Javadoc typos, update reference docs. Original pull request #2036 See #2031
This commit is contained in:
committed by
Jens Schauder
parent
7698d487ba
commit
becc753e2f
@@ -16,6 +16,7 @@
|
||||
package org.springframework.data.jdbc;
|
||||
|
||||
import org.assertj.core.api.SoftAssertions;
|
||||
import org.junit.jupiter.api.Disabled;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.data.auditing.config.AuditingHandlerBeanDefinitionParser;
|
||||
|
||||
@@ -34,6 +35,7 @@ import com.tngtech.archunit.library.dependencies.SlicesRuleDefinition;
|
||||
*
|
||||
* @author Jens Schauder
|
||||
*/
|
||||
@Disabled("Disabled because of JdbcArrayColumns and Dialect cycle to be resolved in 4.0")
|
||||
public class DependencyTests {
|
||||
|
||||
@Test
|
||||
|
||||
@@ -37,6 +37,7 @@ import org.springframework.context.annotation.Primary;
|
||||
import org.springframework.context.annotation.Profile;
|
||||
import org.springframework.data.convert.CustomConversions;
|
||||
import org.springframework.data.jdbc.core.convert.*;
|
||||
import org.springframework.data.jdbc.core.dialect.JdbcArrayColumns;
|
||||
import org.springframework.data.jdbc.core.dialect.JdbcDialect;
|
||||
import org.springframework.data.jdbc.core.mapping.JdbcMappingContext;
|
||||
import org.springframework.data.jdbc.core.mapping.JdbcSimpleTypes;
|
||||
@@ -169,7 +170,8 @@ public class TestConfiguration {
|
||||
CustomConversions conversions, @Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template,
|
||||
Dialect dialect) {
|
||||
|
||||
JdbcArrayColumns arrayColumns = dialect instanceof JdbcDialect ?
|
||||
org.springframework.data.jdbc.core.dialect.JdbcArrayColumns arrayColumns = dialect instanceof JdbcDialect
|
||||
?
|
||||
((JdbcDialect) dialect).getArraySupport() :
|
||||
JdbcArrayColumns.DefaultSupport.INSTANCE;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user