Spring/spring-data-relational
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#64 - Polishing.

Browse Source 
Incorporated feedback from review. Polished documentation and Javadoc. Minor code improvements restructuring for better readability. Removed unused methods types. Some polishing for compiler warnings.

Original pull request: #106.
This commit is contained in:
Oliver Drotbohm
2019-05-08 10:36:21 +02:00
parent 361d801b14
commit da53a9a934
14 changed files with 100 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/java/org/springframework/data/r2dbc/function/query/CriteriaUnitTests.java
View File

@@ -21,8 +21,8 @@ import static org.springframework.data.r2dbc.function.query.Criteria.*;
import java.util.Arrays;
import org.junit.Test;
import org.springframework.data.r2dbc.function.query.Criteria.*;
import org.springframework.data.r2dbc.function.query.Criteria.Combinator;
import org.springframework.data.r2dbc.function.query.Criteria.Comparator;
/**
* Unit tests for {@link Criteria}.

2
src/test/java/org/springframework/data/r2dbc/function/query/QueryMapperUnitTests.java
View File

@@ -20,7 +20,6 @@ import static org.mockito.Mockito.*;
import static org.springframework.data.domain.Sort.Order.*;
import org.junit.Test;
import org.springframework.data.domain.Sort;
import org.springframework.data.r2dbc.dialect.BindMarkersFactory;
import org.springframework.data.r2dbc.domain.BindTarget;
@@ -227,7 +226,6 @@ public class QueryMapperUnitTests {
assertThat(mapped.getOrderFor("alternative")).isNull();
}
@SuppressWarnings("unchecked")
private BoundCondition map(Criteria criteria) {
BindMarkersFactory markers = BindMarkersFactory.indexed("$", 1);

2
src/test/java/org/springframework/data/r2dbc/function/query/UpdateMapperUnitTests.java
View File

@@ -22,7 +22,6 @@ import java.util.Map;
import java.util.stream.Collectors;
import org.junit.Test;
import org.springframework.data.r2dbc.dialect.BindMarkersFactory;
import org.springframework.data.r2dbc.domain.BindTarget;
import org.springframework.data.r2dbc.domain.SettableValue;
@@ -89,7 +88,6 @@ public class UpdateMapperUnitTests {
verifyZeroInteractions(bindTarget);
}
@SuppressWarnings("unchecked")
private BoundAssignments map(Update update) {
BindMarkersFactory markers = BindMarkersFactory.indexed("$", 1);