From ee46695cdd413b13bfe61ed82977ef10f6f31e26 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Mon, 20 Apr 2020 09:39:28 +0200 Subject: [PATCH] #350 - Use Testcontainers constructor with image name. Create database containers using the constructor accepting the image name to make sure that the exposed port gets registered. A recent change in Testcontainers caused that the port is no longer registered when using the default constructor. --- .../springframework/data/r2dbc/testing/MariaDbTestSupport.java | 2 +- .../springframework/data/r2dbc/testing/MySqlTestSupport.java | 2 +- .../data/r2dbc/testing/PostgresTestSupport.java | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java index 0020a375..c250c4c3 100644 --- a/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java +++ b/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java @@ -107,7 +107,7 @@ public class MariaDbTestSupport { if (testContainerDatabase == null) { try { - MariaDBContainer container = new MariaDBContainer(); + MariaDBContainer container = new MariaDBContainer(MariaDBContainer.IMAGE + ":" + MariaDBContainer.DEFAULT_TAG); container.start(); testContainerDatabase = ProvidedDatabase.builder(container) // diff --git a/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java index ee57f0b5..d6012bd1 100644 --- a/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java +++ b/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java @@ -107,7 +107,7 @@ public class MySqlTestSupport { if (testContainerDatabase == null) { try { - MySQLContainer container = new MySQLContainer(); + MySQLContainer container = new MySQLContainer(MySQLContainer.IMAGE + ":" + MySQLContainer.DEFAULT_TAG); container.start(); testContainerDatabase = ProvidedDatabase.builder(container) // diff --git a/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java index 2152e47a..0372923e 100644 --- a/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java +++ b/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java @@ -88,7 +88,8 @@ public class PostgresTestSupport { if (testContainerDatabase == null) { try { - PostgreSQLContainer container = new PostgreSQLContainer(); + PostgreSQLContainer container = new PostgreSQLContainer( + PostgreSQLContainer.IMAGE + ":" + PostgreSQLContainer.DEFAULT_TAG); container.start(); testContainerDatabase = ProvidedDatabase.from(container);