Commit Graph

590 Commits

Author SHA1 Message Date
Mark Paluch
61c6fcfd39 Polishing.
Reduce test element visibility.

See #1750
Original pull request: #1785
2024-05-15 14:56:52 +02:00
Mark Paluch
9e8e3ce64e Move AggregateReference converter registration into MappingJdbcConverter.
See #1750
Original pull request: #1785
2024-05-15 14:56:52 +02:00
Jens Schauder
284509a40f Reuse custom converters from AggregateReferenceConverters.
Let the AggregateReference converters now receive also custom converters as delegates.
Remove the ArrayToObjectConverter which just uses the first element of the array from the DefaultConversion service.

This does NOT solve the underlying problem, of having two DefaultConversionServices at work.
One is in the store conversion, one constructed in the AbstractRelationalConverter.
Although it looks like they get merged, the former contains converters, using that ConversionService as a delegate.

Attempts were made to move AggregateReferenceConverters out of the store converters and just register them directly,
but then no custom read/write targets are detected, leading to failed conversions.
The same problem prevents a registration in CustomConversions as a Function<ConversionService, GenericConverter> or similar, which would allow late registration.
The problem here is that custom read/write targets require the function to get evaluated, before custom read/write targets can be determined.

Closes #1750
Original pull request: #1785
2024-05-15 14:56:47 +02:00
Paul-Christian Volkmer
a03441598e Remove redundant code
createPersistentEntity(..) effectively only calls the overriden method.
It therefore can be deleted.

Remove error message no longer used.

Original pull request #1783
2024-04-30 09:16:39 +02:00
Jens Schauder
792d773cbd Fix broken merge.
See #1721
Original pull request #1722
2024-04-24 15:24:59 +02:00
Jens Schauder
ecdf7039ed Remove check for constructor parameter names.
For Kotlin constructors and possibly others parameters maybe unnamed and still work with our infrastructure.

Closes #1762
2024-04-24 12:18:58 +02:00
Jens Schauder
13ed4baf45 Polishing.
Add author tags.

See #1721
Original pull request #1722
2024-04-23 12:04:43 +02:00
Mark Paluch
f50609f7b1 Performance improvements.
Introduce caching for configured RowMapper/ResultSetExtractor.

We now create RowMapper/ResultSetExtractor instances only once if they are considered static configuration.
A configured RowMapper ref/class is always static.
A configured ResultSetExtractor ref/class is static when the extractor does not accept a RowMapper or if the RowMapper is configured.

Default mappers or projection-specific ones require ResultSetExtractor recreation of the ResultSetExtractor is configured as Class.

Reuse TypeInformation as much as possible to avoid Class -> TypeInformation conversion.
Introduce LRU cache for DefaultAggregatePath to avoid PersistentPropertyPath lookups.
Introduce best-effort quoted cache for SqlIdentifier to avoid excessive string object creation.

Closes #1721
Original pull request #1722
2024-04-23 12:04:43 +02:00
Jens Schauder
9b41c1d236 Fix access of root property instead of child property.
When the child of a one-to-one relationship has an id, the value for that id gets read in the wrong way.
We get the column name for that id use that to access the value in the RowDocument.

This results in either no value at all being found or even worse, the value of a root entity with a property of same name being accessed.

This is fixed by using the full AggregatePath instead of just the property for accessing that value.

Closes #1684
Original pull request: #1775
2024-04-22 09:29:59 +02:00
Jens Schauder
b22ccad36d Fix loading of 2nd level collections.
Construction of the back reference assumed that the table holding the parent of the foreign key is the actual parent property.
This is now corrected by using the correct API to identify the ancestor which holds the id.

Closes: #1692
Original pull request: #1773
2024-04-18 10:28:39 +02:00
Mark Paluch
93fe8604ff Prepare next development iteration.
See #1753
2024-04-12 10:17:28 +02:00
Mark Paluch
0d5a9c036f Release version 3.2.5 (2023.1.5).
See #1753
2024-04-12 10:15:11 +02:00
Mark Paluch
66b5877df5 Prepare next development iteration.
See #1741
2024-03-15 10:20:08 +01:00
Mark Paluch
fd3ada182e Release version 3.2.4 (2023.1.4).
See #1741
2024-03-15 10:17:49 +01:00
Mark Paluch
4f16e5f312 Prepare next development iteration.
See #1718
2024-02-16 13:53:51 +01:00
Mark Paluch
ea5a612dd2 Release version 3.2.3 (2023.1.3).
See #1718
2024-02-16 13:50:30 +01:00
Mark Paluch
523b5e6091 Prepare next development iteration.
See #1703
2024-01-12 10:54:32 +01:00
Mark Paluch
ba143f8886 Release version 3.2.2 (2023.1.2).
See #1703
2024-01-12 10:51:32 +01:00
Jens Schauder
252ca6218f Nested tests now get properly executed.
See 9a00e62fe7
See #1681
2024-01-03 14:59:31 +01:00
Jens Schauder
00d23e65ec Properly delegate method calls for EscapingParameterSource.
Closes #1681
See #1682
2024-01-03 14:59:31 +01:00
Mark Paluch
b1002fe124 Extend license header copyright years to 2024.
See #1708
2024-01-02 13:55:08 +01:00
Mark Paluch
4544fd710d Prepare next development iteration.
See #1671
2023-12-15 14:15:20 +01:00
Mark Paluch
d8815d924e Release version 3.2.1 (2023.1.1).
See #1671
2023-12-15 14:11:53 +01:00
Mark Paluch
60520648c4 Polishing.
Remove duplicate and unused code.

See #1695
2023-12-14 08:08:51 +01:00
Mark Paluch
c84f846f5e Wrap associations in EmbeddedRelationalPersistentEntity.
We now also wrap associations to ensure embedded prefix propagation.

Closes #1695
2023-12-14 08:08:50 +01:00
Jens Schauder
e5bcc4a155 Fix loading of nested embedded entities.
Closes #1676
Original pull request: #1685
2023-12-13 14:34:47 +01:00
Mark Paluch
f9c6aaeec7 Create PartTree against the domain type.
We now derive queries against the domain type and no longer using the result type to ensure query mapping and query creation against the domain type.

Closes #1688
2023-12-05 15:46:37 +01:00
Mark Paluch
ee01650a7f Reuse TypeInformation during PersistentPropertyPath and PersistentEntity lookups.
We now avoid Class -> TypeInformation conversion if we already have TypeInformation at hand.

Closes #1679
2023-11-29 09:48:35 +01:00
Jens Schauder
72bbcc4fc4 Switch to Testcontainers Oracle Free.
Timeout increased from the default because that cause problems on CI.
Brought SD JDBC now uses `ojdbc11` as R2DBC.

Closes #1665
Original pull request #1668
2023-11-20 15:32:16 +01:00
Mark Paluch
89f34105ad Polishing.
Reformat code.

See #1666
Original pull request: #1667
2023-11-20 14:46:54 +01:00
Jens Schauder
2be10dd5fd Support for Id generation in Oracle using quoted identifiers.
The latest Oracle JDBC driver properly supports returning of generated ids,
both in batches and for quoted identifiers.

This allows us to now support this feature.

Closes #1666
Original pull request: #1667
2023-11-20 14:46:54 +01:00
Mark Paluch
cce7499f20 Prepare next development iteration.
See #1642
2023-11-17 14:33:54 +01:00
Mark Paluch
fe6d599d8b Release version 3.2 GA (2023.1.0).
See #1642
2023-11-17 14:29:59 +01:00
Jens Schauder
42e786ca78 Fix Oracle database setup script.
Changed BIGINT to NUMBER.

See #1656
Original pull request #1663
2023-11-16 20:38:49 +01:00
Jens Schauder
15bb8d1eef Properly convert Map keys.
Keys of maps now get properly converted.
Among others this enables the use of enums as keys.

Closes #1656
Original pull request: #1663
2023-11-16 10:42:15 +01:00
Mark Paluch
5312731623 Reject Limit parameter using String-based queries.
Document limitations, add test cases for derived queries.

Closes #1654
2023-11-02 09:26:43 +01:00
Jens Schauder
6736d8334e Add conversion capabilities to the entity instantiator.
Closes #1646
2023-10-17 16:54:11 +02:00
Jens Schauder
3c7cbcfeeb Polishing.
Original pull request #1636
2023-10-16 11:01:23 +02:00
Simon Verhoeven
4062237e04 Update readme.
Cleanup.

Original pull request #1636
2023-10-16 11:01:15 +02:00
John Blum
b7855d010f Prepare next development iteration.
See #1614
2023-10-13 08:51:59 -07:00
John Blum
74ae9af708 Release version 3.2 RC1 (2023.1.0).
See #1614
2023-10-13 08:44:26 -07:00
Jens Schauder
8ba1204b2a Polishing.
Original pull request #1618
See #1554
2023-10-13 11:04:55 +02:00
Mark Paluch
5344197ba6 Fix identifier propagation for no-id list elements.
Original pull request #1618
See #1554
2023-10-13 10:28:30 +02:00
Mark Paluch
5398b94020 Deprecate Basic…Converter infrastructure.
Merge basic converters into Mapping…Converters and introduce deprecated variant to provide guidance for migration off the deprecated types.

Cleanup no longer required code.

Original pull request #1618
See #1554
2023-10-13 10:28:18 +02:00
Mark Paluch
4e3120ee0e Migrate JDBC to use RowDocument for reading aggregates.
Original pull request #1618
See #1554
2023-10-13 10:28:11 +02:00
Jens Schauder
9c36eb970b Fix MS Sql Server integration tests.
Closes #1638
2023-10-11 15:54:56 +02:00
Jens Schauder
210b63fcb4 Add failsafe:verify goal as an execution.
The failsafe plugin only fails during it's verify goal, not when actually executing the tests.

The goal is by default added to the verify phase.
But for the database tests this adds it to the integration-test phase.
This ensures that the build fail as soon a test for one database fails.

Closes #1637
2023-10-11 13:54:47 +02:00
Mark Paluch
a72bf1a65d Polishing.
Delegate BatchJdbcOperations calls to NamedParameterJdbcOperations. Refine since and deprecation tags.

See #1616
2023-10-11 09:54:44 +02:00
Jens Schauder
5d6d575ab2 Replace BatchJdbcOperations with Spring's NamedParameterJdbcOperations.
BatchJdbcOperations is still there, but deprecated, and not used except for deprecated places kept for backward compatibility.

This is possible since Spring Framework made the features offered by `BatchJdbcOperations` part of `NamedParameterJdbcOperations`.

Closes #1616
2023-10-11 09:54:44 +02:00
Jens Schauder
ddec3cc531 Adapt to new test infrastructure.
Originial pull request #1222
See #1220
See #1620
2023-10-10 08:34:05 +02:00