Commit Graph

141 Commits

Author SHA1 Message Date
Oliver Gierke
e680a2764e DATAJDBC-245 - Prepare 1.0 RC2 (Lovelace). 2018-08-20 10:39:44 +02:00
Oliver Gierke
6c6d37af2d DATAJDBC-245 - Updated changelog. 2018-08-20 10:39:43 +02:00
Jens Schauder
e398db544c DATAJDBC-241 - Support for immutable entities.
Immutable entities can now be saved and loaded and the immutability will be honored.

This feature is currently limited to a single level of reference.

In order to implement this the logic for updating IDs with those generated from the database got moved out of the DefaultDataAccessStrategy into the AggregateChange.
As part of that move DataAccessStrategy.save now returns a generated id, if available.

See also: DATAJDBC-248.
2018-08-20 09:42:22 +02:00
Mark Paluch
eb69f4206c DATAJDBC-242 - Polishing.
Slight rewording of individual parts. Include namespace/populator/return type includes. Use spring-framework-docs variable where possible.

Original pull request: #81.
2018-08-02 09:56:20 +02:00
Jens Schauder
2642d1be8f DATAJDBC-242 - Updated documentation.
Introduced variable for linking to JavaDoc.
Used the `revnumber` in there in order to link to the proper version of the JavaDoc.
Changed package and class names matching the changes of DATAJDBC-226.
Fixed some typos.

Original pull request: #81.
2018-08-02 09:56:14 +02:00
Jens Schauder
4c179a93ec DATAJDBC-229 - Added UUID.class as simple type.
Also made RelationalMappingContext actually use the JdbcSimpleTypes.

In order for this to work the database needs to be able to handle parameters of type UUID and store them either as such or internally convert them.
Currently no conversion by Spring Data JDBC happens.

Original pull request: #76.
2018-07-27 14:37:45 +02:00
Toshiaki Maki
21c9bd2144 DATAJDBC-229 Added test demonstrating java.util.UUID is not a simple type.
Original pull request: #76.
2018-07-27 14:33:07 +02:00
Mark Paluch
264235703e DATAJDBC-215 - Prepare 1.0 RC1 (Lovelace). 2018-07-26 12:04:31 +02:00
Mark Paluch
7ab5d3f32d DATAJDBC-215 - Updated changelog. 2018-07-26 12:04:29 +02:00
Mark Paluch
d30116921e DATAJDBC-243 - Remove JdbcConfiguration import in EnableJdbcRepositories.
We now no longer import JdbcConfiguration to prevent bean overrides when creating a configuration class that extends JdbcConfiguration. Using EnableJdbcRepositories requires either an import of the configuration class inside the application code or registration of the required RelationalConverter and RelationalMappingContext beans.

Related ticket: DATAJDBC-244
2018-07-26 10:38:46 +02:00
Mark Paluch
6c79b04033 DATAJDBC-233 - Polishing.
Enhance Javadoc. Fix generics for AggregateChange in JdbcAggregateTemplate. Use Lombok's Data annotation where possible. Typos.

Original pull request: #80.
2018-07-25 09:26:37 +02:00
Jens Schauder
1085918135 DATAJDBC-233 - Changed API in order to support immutable entities.
Note: Immutable entities still aren't supported yet, these are just the API changes plus implementations that work for mutable entities.

The API of DbActions will need further evolution.

Original pull request: #80.
2018-07-25 09:26:32 +02:00
Jens Schauder
962513627c DATAJDBC-235 - JdbcConfiguration is now suitable to be extended.
All the methods in JdbcConfiguration are now protected so the class can be extended and the methods overwritten in order to customize the configuration of Spring Data JDBC.
2018-07-20 16:35:39 +02:00
Jens Schauder
0445aa61db DATAJDBC-238 - JdbcRepositoryFactory.getEntityInformation never returns null.
Instead it throws an exception as this is required by the interface it implements.
2018-07-20 13:49:43 +02:00
Jens Schauder
8ee15fb1fd DATAJDBC-237 - Removed @since annotations.
@since annotation are only supposed to be used for classes introduced after the initial release.
2018-07-20 13:39:51 +02:00
Mark Paluch
12d539a017 DATAJDBC-227 - Polishing.
Return List<DbChange<?>> in RelationalEntityWriters so AggregateChange can be assembled in less places to reduce the number of abstractions per method. Change ResultOrException in FunctionCollector to static class so instances no longer retain a reference to their enclosing class. Fix DbAction generics in AggregateChange. Replace simple constructors with Lombok usage. Javadoc, typos, formatting.

Original pull request: #79.
2018-07-19 15:34:01 +02:00
Jens Schauder
bdefd3da9a DATAJDBC-227 - Refactored JdbcEntityWriter and DbActions.
JdbcEntityWriter and JdbcDeleteEntityWriter now use an iterative approach based on PersistentPropertyPath instead of a recursive one.

DbAction is now split into multiple interfaces representing different variants of actions.
The implementations are simple value types without any implementation inheritance hierarchy.
All elements of a DbAction implementation are not null making usage and construction of instances much easier.

Original pull request: #79.
2018-07-19 15:33:46 +02:00
Jens Schauder
c412aad6b8 DATAJDBC-235 - Polishing.
Corrected nullability annotations.
Minor improvements in Javadoc.
Added @author tags.
Removed unused imports.
2018-07-19 10:38:52 +02:00
Mark Paluch
2c5489b070 DATAJDBC-235 - Incorporate feedback from review.
Refactor ResultSetParameterValueProvider into Function<Parameter, Object>. Remove unnecessary assertions.
2018-07-19 10:38:52 +02:00
Mark Paluch
fb858bf1b1 DATAJDBC-235 - Add support for configurable conversion.
We now support configurable conversion by introducing CustomConversions and RelationalConverter. CustomConversions is a registry for converters that should be applied on a per-type basis for properties. CustomConversions is typically registered as bean and fed into RelationalMappingContext and the newly introduced RelationalConverter to consider simple types and conversion rules.

RelationalConverter with its implementation BasicRelationalConverter encapsulates conversion infrastructure such as EntityInstantiator, CustomConversions, and MappingContext that is required during relational value conversion. BasicRelationalConverter is responsible for simple value conversion and entity instantiation to pull related code together. It's not in full charge of row result to object mapping as this responsibility remains as part of DataAccessStrategy.

This change supersedes and removes ConversionCustomizer.
2018-07-19 10:38:52 +02:00
Oliver Gierke
95d316367b DATAJDBC-232 - Adapt code to changes to support immutable entities.
We now treat all properties of an entity mutable and continue to use the reflective PersistentPropertyAccessor implementation to make sure we don't break the old behavior of reflectively mutating immutable objects.

This is a workaround for now and has to be replaced by more exhaustive changes later.

Related tickets: DATACMNS-1322.
2018-07-13 16:50:30 +02:00
Oliver Gierke
9991946d92 DATAJDBC-226 - Renamed all types named Jdbc… in relational package Relational…. 2018-06-22 15:40:32 +02:00
Oliver Gierke
8a67e52b61 DATAJDBC-226 - Extracted packages not directly tied to JDBC into separate package. 2018-06-22 15:33:13 +02:00
Jens Schauder
0a0e774129 DATAJDBC-137 - Fixes warnings and improves Javadoc.
All packages now use @NoNullApi.
All warnings related to that fixed, except a few cases where upstream annotations are simply wrong.
Added null checks.
Fixed generic types where possible.
Improved Javadoc.
Code Formatting.
2018-06-11 16:15:52 +02:00
Mark Paluch
b9c6b8b943 DATAJDBC-102 - Polishing.
Pull entity instantiation into a single method.

Original pull request: #68.
2018-06-04 16:12:59 +02:00
Jens Schauder
b91da91a83 DATAJDBC-102 - Polishing.
Execute Hsql specific integration test only with Hsql.

Original pull request: #68.
2018-06-04 16:12:59 +02:00
Jens Schauder
0ebb4a7799 DATAJDBC-102 - Determine the EntityInstantiator to be used dynamically.
Replaced the direct use of EntityInstantiator with EntityInstantiators.
Moved it into the MappingContext because instantiation is part of the mapping process.

Original pull request: #68.
2018-06-04 16:12:59 +02:00
Jay Bryant
17476391fe DATAJDBC-222 - Full editing pass for Spring Data JDBC.
Edited for spelling, punctuation, grammar, usage, and corporate voice.
Also added an epub cover image and the SVG file from which it can be generated.

Original pull request: #73.
2018-06-04 07:40:51 +02:00
Oliver Gierke
fca2ef6629 DATAJDBC-137 - Improve EntityInformation usage.
Moved to both the usage of the newly introduced PersistentEntity.isNew(…) and identifier lookups via PersistentEntity instead of using a custom EntityInformation implementation. JdbcRepositoryFactory now creates a PersistentEntityInformation, SimpleJdbcRepository simply works with a PersistentEntity.

Removed references to EntityInformation (a repository subsystem concept) from the template implementation. Removed BasicJdbcPersistentEntity and its tests entirely. JdbcAuditingEventListener is now using an IsNewAwareAuditingHandler.

Related tickets: DATACMNS-1333.
2018-05-31 22:28:06 +02:00
Jens Schauder
6bf916b9c4 DATAJDBC-207 - Polishing.
Formatting.
2018-05-23 15:24:43 -05:00
Jens Schauder
b4b6625d50 DATAJDBC-207 - Default NamingStrategy is now Snake Case.
Moved the implementation from the DelimiterNamingStrategy into the NamingStrategy.
Dropped the support for different separators, since there is no good way to support it in the default implementations of an interface.
A getSeparator() method would bleed into the public API.
Also the added value of that flexibility seems limited.

During migration of the various test it became obvious that SqlGeneratorUnitTests was broken since test failures happend on a worker thread not on the main test thread.
This is fixed as well with this commit.
2018-05-23 15:24:35 -05:00
Jens Schauder
0460f2f509 DATAJDBC-188 - Ensure proper behavior of delete logic.
No behavior changed.
Added tests on various levels for deleting entities with references to other entities.
2018-05-23 15:15:50 -05:00
Jens Schauder
bd9b1ed301 DATAJDBC-174 - First version of a reference documentation. 2018-05-23 15:10:25 -05:00
Jens Schauder
01478cc53d DATAJDBC-143 - Removed domain type parameter form JdbcEntityOperations.save().
Such a parameter would only make sense with inheritance and we don't support inheritance at all in the moment.
Anything we need in order to support inheritance should be added once we do support inheritance.
2018-05-23 15:05:09 -05:00
Jens Schauder
387c3eca18 DATAJDBC-220 - Added a Degraph test for inter module dependencies.
The existing test only analysed Spring Data JDBC itself.
The new test also considers packages from commons and treats

    org.springframework.data.x.X

and

    org.springframework.data.jdbc.x.Y

as belonging to the same "sub-module" "x".
2018-05-22 15:41:21 +02:00
Oliver Gierke
e4de5701d4 DATAJDBC-138 - Polishing.
Moved all types from mapping.model into model to align with the setup of other Spring Data modules.

Original pull request: #67.
2018-05-18 16:35:13 +02:00
Jens Schauder
bd7401b665 DATAJDBC-138 - Improve package structure and naming.
Moved SimpleJdbcRepository into support package.
Moved mapping package under core.
Renamed JdbcEntityOperations to JdbcAggregateOperations.
2018-05-18 16:35:13 +02:00
Oliver Gierke
d0a8af21a3 DATAJDBC-137 - Polishing.
Moved the dependency to NamedParameterJdbcOperations out of JdbcMappingContext. This revealed that despite the DataAccessStrategy abstraction, there are a couple of places in the query execution subsystem that work with a plain NamedParameterJdbcOperations instance, so that we now have to carry that around all the way from the repository factory bean. Improving that is subject for further changes.

A bit of JavaDoc and generics polish here and there.
2018-05-18 15:11:27 +02:00
Oliver Gierke
fbc271a83a DATAJDBC-106 - Polishing.
Moved annotation processing of @Table and @Column into metamodel classes so that the NamingStrategy is only responsible for generic fallbacks. Allow @Column to be used as meta-annotation.
2018-05-18 13:57:46 +02:00
Oliver Gierke
eab63d8848 DATAJDBC-137 - Cleanups in the repository and repository.support packages. 2018-05-18 12:30:38 +02:00
Jens Schauder
fe98964d72 DATAJDBC-216 - Polishing.
Simplified code by using constructor injection plus Lombok.
Removed superfluous handling of BeforeSave events with null entity.

Original pull request: #71.
2018-05-18 07:53:45 +02:00
Kazuki Shimizu
0c863eb180 DATAJDBC-216 - Support @Id property primitive type for auditing.
The new check is now properly done using Spring Data meta Informationen.

Original pull request: #71.
2018-05-18 07:52:02 +02:00
Jens Schauder
46a07ac9f7 DATAJDBC-106 - Polishing.
Formatting and Javadoc.

Original pull request: #65
2018-05-17 16:07:57 +02:00
Kazuki Shimizu
cd7403907a DATAJDBC-106 - Support to specify a database object names using annotations.
@Table and @Column annotation added for configuring table and column names.

Original pull request: #65.
2018-05-17 16:06:40 +02:00
Christoph Strobl
1b8c6111db DATAJDBC-202 - Prepare 1.0 M3 (Lovelace). 2018-05-17 09:50:48 +02:00
Christoph Strobl
1c60426976 DATAJDBC-202 - Updated changelog. 2018-05-17 09:50:47 +02:00
Oliver Gierke
35fa0d184c DATAJDBC-212 - Adapt to SpEL extension API changes in Spring Data Commons.
Related tickets: DATACMNS-1260.
2018-05-15 11:10:08 +02:00
Jens Schauder
f1e36a73e1 DATAJDBC-209 - Polishing.
Added a comment to explain why we have to use a Timestamp for the comparison.

Original pull request: #66.
2018-05-15 10:35:04 +02:00
Kazuki Shimizu
52a8daf003 DATAJDBC-209 - Improve assertion on The QueryAnnotationHsqlIntegrationTests#executeCustomQueryWithReturnTypeIsDate
Since Timestamp extends Date the repository returns the Timestamp as it comes from the database.
Trying to compare that to an actual Date results in non determistic results, so we have to use an actual Timestamp.

Original pull request: #66.
2018-05-15 10:33:37 +02:00
Jens Schauder
41e31b1916 DATAJDBC-201 - Reduced logging for builds.
Set logging level to WARN.
Removed a System.out call.

The detail loggers are still in the logback.xml as comments to be used for debugging and demonstration purposes.
2018-04-17 15:37:28 +02:00