Spring/spring-data-rest
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREST-539 - Log exception even if it has no message.

Browse Source
This commit is contained in:
Antoine Vandecreme
2015-05-11 10:47:25 -04:00
committed by Oliver Gierke
parent 8b3c629c8e
commit 4b3d4dce8b
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryRestExceptionHandler.java
View File

@@ -33,6 +33,7 @@ import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity; import org.springframework.http.ResponseEntity;
import org.springframework.http.converter.HttpMessageNotReadableException; import org.springframework.http.converter.HttpMessageNotReadableException;
import org.springframework.util.Assert; import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
import org.springframework.web.HttpRequestMethodNotSupportedException; import org.springframework.web.HttpRequestMethodNotSupportedException;
import org.springframework.web.bind.annotation.ControllerAdvice; import org.springframework.web.bind.annotation.ControllerAdvice;
import org.springframework.web.bind.annotation.ExceptionHandler; import org.springframework.web.bind.annotation.ExceptionHandler;
@@ -161,16 +162,17 @@ public class RepositoryRestExceptionHandler {
private static ResponseEntity<ExceptionMessage> errorResponse(HttpStatus status, HttpHeaders headers, private static ResponseEntity<ExceptionMessage> errorResponse(HttpStatus status, HttpHeaders headers,
Exception exception) { Exception exception) {
if (null != exception && null != exception.getMessage()) { if (exception != null) {
LOG.error(exception.getMessage(), exception); String message = exception.getMessage();
LOG.error(message, exception);
return response(status, headers, new ExceptionMessage(exception)); if (StringUtils.hasText(message)) {
return response(status, headers, new ExceptionMessage(exception));
} else { }
return response(status, headers, null);
} }
return response(status, headers, null);
} }
private static <T> ResponseEntity<T> response(HttpStatus status, HttpHeaders headers) { private static <T> ResponseEntity<T> response(HttpStatus status, HttpHeaders headers) {