From 9bbe4c97eb17c375869cc77018bdac22cbc2c593 Mon Sep 17 00:00:00 2001 From: Oliver Drotbohm Date: Tue, 13 Jul 2021 15:13:28 +0200 Subject: [PATCH] Ensure buildability on JDK 16. Properly initialize the MongoMappingContext in unit tests when using special identifier types. Explicitly add javax.annotation as dependency in shop tests. --- .../rest/webmvc/config/JsonPatchHandlerUnitTests.java | 5 +++++ .../spring-data-rest-tests-shop/pom.xml | 9 +++++++++ 2 files changed, 14 insertions(+) diff --git a/spring-data-rest-tests/spring-data-rest-tests-mongodb/src/test/java/org/springframework/data/rest/webmvc/config/JsonPatchHandlerUnitTests.java b/spring-data-rest-tests/spring-data-rest-tests-mongodb/src/test/java/org/springframework/data/rest/webmvc/config/JsonPatchHandlerUnitTests.java index 78ad113f7..0fbc3e6db 100755 --- a/spring-data-rest-tests/spring-data-rest-tests-mongodb/src/test/java/org/springframework/data/rest/webmvc/config/JsonPatchHandlerUnitTests.java +++ b/spring-data-rest-tests/spring-data-rest-tests-mongodb/src/test/java/org/springframework/data/rest/webmvc/config/JsonPatchHandlerUnitTests.java @@ -21,6 +21,7 @@ import static org.springframework.data.rest.tests.mongodb.TestUtils.*; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -28,6 +29,7 @@ import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; import org.springframework.data.mapping.context.PersistentEntities; +import org.springframework.data.mongodb.core.convert.MongoCustomConversions; import org.springframework.data.mongodb.core.mapping.MongoMappingContext; import org.springframework.data.rest.core.config.RepositoryRestConfiguration; import org.springframework.data.rest.core.mapping.ResourceMappings; @@ -56,7 +58,10 @@ class JsonPatchHandlerUnitTests { @BeforeEach void setUp() { + MongoCustomConversions conversions = new MongoCustomConversions(Collections.emptyList()); + MongoMappingContext context = new MongoMappingContext(); + context.setSimpleTypeHolder(conversions.getSimpleTypeHolder()); context.getPersistentEntity(User.class); PersistentEntities entities = new PersistentEntities(Arrays.asList(context)); diff --git a/spring-data-rest-tests/spring-data-rest-tests-shop/pom.xml b/spring-data-rest-tests/spring-data-rest-tests-shop/pom.xml index 055d7b884..b69541488 100644 --- a/spring-data-rest-tests/spring-data-rest-tests-shop/pom.xml +++ b/spring-data-rest-tests/spring-data-rest-tests-shop/pom.xml @@ -30,6 +30,15 @@ ${springdata.keyvalue} + + + + javax.annotation + javax.annotation-api + 1.3.2 + test + +