DATAREST-1304 - EntityLookupConfiguration is now used in PUT for creation.

Previously the backend identifier derived from the URI was set as identifier on the object to be created in a PUT request. However, in case a custom entity lookup is used, this is not the identifier but an arbitrary property pointed to through user defined code, mostly a method reference.

We now use the newly introduced MethodInvocationRecorder API in Spring Data Commons to be able to obtain the property that is supposed to be used and set that to the value calculated. This requires the entity type for which the custom lookup is configured to be non-final as the invocation recording is build on top of proxies.

Related tickets: DATACMNS-1449.

spring-data-rest-core/src/test/java/org/springframework/data/rest/core/RepositoryRestConfigurationIntegrationTests.java

@@ -19,9 +19,15 @@ import static org.assertj.core.api.Assertions.*;
 
 import org.junit.Test;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.data.repository.support.Repositories;
 import org.springframework.data.rest.core.config.RepositoryRestConfiguration;
 import org.springframework.data.rest.core.config.ResourceMapping;
 import org.springframework.data.rest.core.domain.ConfiguredPersonRepository;
+import org.springframework.data.rest.core.domain.Profile;
+import org.springframework.data.rest.core.domain.ProfileRepository;
+import org.springframework.data.rest.core.support.EntityLookup;
+import org.springframework.plugin.core.PluginRegistry;
+import org.springframework.test.annotation.DirtiesContext;
 
 /**
  * Tests to check that {@link ResourceMapping}s are handled correctly.
@@ -33,6 +39,7 @@ import org.springframework.data.rest.core.domain.ConfiguredPersonRepository;
 public class RepositoryRestConfigurationIntegrationTests extends AbstractIntegrationTests {
 
 	@Autowired RepositoryRestConfiguration config;
+	@Autowired Repositories repositories;
 
 	@Test
 	public void shouldProvideResourceMappingForConfiguredRepository() throws Exception {
@@ -44,4 +51,20 @@ public class RepositoryRestConfigurationIntegrationTests extends AbstractIntegra
 		assertThat(mapping.getPath()).isEqualTo("people");
 		assertThat(mapping.isExported()).isFalse();
 	}
+
+	@Test // DATAREST-1304
+	@DirtiesContext
+	public void exposesLookupPropertyFromLambda() {
+
+		config.withEntityLookup() //
+				.forRepository(ProfileRepository.class) //
+				.withIdMapping(Profile::getName) //
+				.withLookup(ProfileRepository::findByName);
+
+		PluginRegistry<EntityLookup<?>, Class<?>> lookups = PluginRegistry.of(config.getEntityLookups(repositories));
+
+		assertThat(lookups.getPluginFor(Profile.class)).hasValueSatisfying(it -> {
+			assertThat(it.getLookupProperty()).hasValue("name");
+		});
+	}
 }

spring-data-rest-core/src/test/java/org/springframework/data/rest/core/domain/Profile.java

@@ -16,6 +16,7 @@
 package org.springframework.data.rest.core.domain;
 
 import lombok.Value;
+import lombok.experimental.NonFinal;
 
 import java.util.UUID;
 
@@ -25,6 +26,7 @@ import org.springframework.data.annotation.Id;
  * @author Jon Brisbin
  * @author Oliver Gierke
  */
+@NonFinal
 @Value
 public class Profile {
 

spring-data-rest-core/src/test/java/org/springframework/data/rest/core/domain/ProfileRepository.java

@@ -25,4 +25,7 @@ import org.springframework.data.repository.CrudRepository;
  * @author Jon Brisbin
  * @author Oliver Gierke
  */
-public interface ProfileRepository extends CrudRepository<Profile, UUID> {}
+public interface ProfileRepository extends CrudRepository<Profile, UUID> {
+
+	Profile findByName(String name);
+}