Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refine MethodParameter#isOptional Kotlin implementation

Browse Source 
This commit adds support for Continuation parameter that is now
considered as an optional parameter since it is never provided by
the user.

It also simplifies and optimizes the implementation.

Closes gh-23991
This commit is contained in:
Sébastien Deleuze
2019-11-14 14:22:44 +01:00
parent 7991066345
commit 029e61f54a
2 changed files with 33 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-core/src/test/kotlin/org/springframework/core/KotlinMethodParameterTests.kt
View File

@@ -20,6 +20,7 @@ import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test
import java.lang.reflect.Method
import java.lang.reflect.TypeVariable
import kotlin.coroutines.Continuation
import kotlin.reflect.full.declaredFunctions
import kotlin.reflect.jvm.javaMethod
@@ -101,6 +102,13 @@ class KotlinMethodParameterTests {
assertThat(returnGenericParameterType("suspendFun8")).isEqualTo(Object::class.java)
}
@Test
fun `Continuation parameter is optional`() {
val method = this::class.java.getDeclaredMethod("suspendFun", String::class.java, Continuation::class.java)
assertThat(MethodParameter(method, 0).isOptional).isFalse()
assertThat(MethodParameter(method, 1).isOptional).isTrue()
}
private fun returnParameterType(funName: String) = returnMethodParameter(funName).parameterType
private fun returnGenericParameterType(funName: String) = returnMethodParameter(funName).genericParameterType
private fun returnGenericParameterTypeName(funName: String) = returnGenericParameterType(funName).typeName