Fix parameter bug of handler inside the filterFunction DSL
Co-authored-by: hojongs <hojong.jjh@gmail.com> Co-authored-by: bjh970913 <bjh970913@gmail.com> Closes gh-26838
This commit is contained in:
committed by
Sébastien Deleuze
parent
0468ef46ac
commit
07ba95739b
@@ -649,8 +649,8 @@ class RouterFunctionDsl internal constructor (private val init: (RouterFunctionD
|
||||
*/
|
||||
fun filter(filterFunction: (ServerRequest, (ServerRequest) -> ServerResponse) -> ServerResponse) {
|
||||
builder.filter { request, next ->
|
||||
filterFunction(request) {
|
||||
next.handle(request)
|
||||
filterFunction(request) { handlerRequest ->
|
||||
next.handle(handlerRequest)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -127,6 +127,13 @@ class RouterFunctionDslTests {
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun filtering() {
|
||||
val servletRequest = PathPatternsTestUtils.initRequest("GET", "/filter", true)
|
||||
val request = DefaultServerRequest(servletRequest, emptyList())
|
||||
assertThat(sampleRouter().route(request).get().handle(request).headers().getFirst("foo")).isEqualTo("bar")
|
||||
}
|
||||
|
||||
private fun sampleRouter() = router {
|
||||
(GET("/foo/") or GET("/foos/")) { req -> handle(req) }
|
||||
"/api".nest {
|
||||
@@ -160,6 +167,18 @@ class RouterFunctionDslTests {
|
||||
path("/baz", ::handle)
|
||||
GET("/rendering") { RenderingResponse.create("index").build() }
|
||||
add(otherRouter)
|
||||
add(filterRouter)
|
||||
}
|
||||
|
||||
private val filterRouter = router {
|
||||
"/filter" { request ->
|
||||
ok().header("foo", request.headers().firstHeader("foo")).build()
|
||||
}
|
||||
|
||||
filter { request, next ->
|
||||
val newRequest = ServerRequest.from(request).apply { header("foo", "bar") }.build()
|
||||
next(newRequest)
|
||||
}
|
||||
}
|
||||
|
||||
private val otherRouter = router {
|
||||
|
||||
Reference in New Issue
Block a user