From 090e394fb55f6df80451934784ac61328da0b5f0 Mon Sep 17 00:00:00 2001 From: izeye Date: Tue, 8 Jun 2021 20:27:35 +0900 Subject: [PATCH] Clean up @SuppressWarnings("ConstantConditions") --- .../support/DefaultMessageHandlerMethodFactory.java | 3 +-- .../support/RSocketFrameTypeMessageCondition.java | 1 - .../org/springframework/web/cors/CorsConfiguration.java | 6 ++---- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/DefaultMessageHandlerMethodFactory.java b/spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/DefaultMessageHandlerMethodFactory.java index c3feebc1a0..b3da10249d 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/DefaultMessageHandlerMethodFactory.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/DefaultMessageHandlerMethodFactory.java @@ -120,8 +120,7 @@ public class DefaultMessageHandlerMethodFactory * the ones configured by default. This is an advanced option. For most use cases * it should be sufficient to use {@link #setCustomArgumentResolvers(java.util.List)}. */ - @SuppressWarnings("ConstantConditions") - public void setArgumentResolvers(List argumentResolvers) { + public void setArgumentResolvers(@Nullable List argumentResolvers) { if (argumentResolvers == null) { this.argumentResolvers.clear(); return; diff --git a/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketFrameTypeMessageCondition.java b/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketFrameTypeMessageCondition.java index b361593781..71dcee0940 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketFrameTypeMessageCondition.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketFrameTypeMessageCondition.java @@ -131,7 +131,6 @@ public class RSocketFrameTypeMessageCondition extends AbstractMessageCondition message) { return (FrameType) message.getHeaders().get(RSocketFrameTypeMessageCondition.FRAME_TYPE_HEADER); diff --git a/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java b/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java index a8bfd18204..3d69879e1e 100644 --- a/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java +++ b/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java @@ -156,8 +156,7 @@ public class CorsConfiguration { /** * Variant of {@link #setAllowedOrigins} for adding one origin at a time. */ - @SuppressWarnings("ConstantConditions") - public void addAllowedOrigin(String origin) { + public void addAllowedOrigin(@Nullable String origin) { if (origin == null) { return; } @@ -222,8 +221,7 @@ public class CorsConfiguration { * Variant of {@link #setAllowedOriginPatterns} for adding one origin at a time. * @since 5.3 */ - @SuppressWarnings("ConstantConditions") - public void addAllowedOriginPattern(String originPattern) { + public void addAllowedOriginPattern(@Nullable String originPattern) { if (originPattern == null) { return; }