Preserve shadowed fields in DirectFieldAccessor

Prior to this change, DirectFieldAccessor would ignore fields shadowed
in subclasses, favoring the last field processed, which happens to be
the most super declaration based on the way ReflectionUtils.doWithFields
works.

Because the locally shadowed field may be of a different type that the
superclass declaration, it is most correct to preserve and work with
the shadowed field.

Issue: SPR-8398
This commit is contained in:
Chris Beams
2011-06-16 06:33:44 +00:00
parent 2aaf14e96f
commit 0e9e63e082
2 changed files with 53 additions and 4 deletions

View File

@@ -0,0 +1,45 @@
/*
* Copyright 2002-2011 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.beans;
import static org.junit.Assert.assertEquals;
import javax.swing.JPanel;
import javax.swing.JTextField;
import org.junit.Test;
/**
* Unit tests for {@link DirectFieldAccessor}
*
* @author Jose Luis Martin
* @author Chris Beams
*/
public class DirectFieldAccessorTests {
@Test
public void withShadowedField() throws Exception {
@SuppressWarnings("serial")
JPanel p = new JPanel() {
@SuppressWarnings("unused")
JTextField name = new JTextField();
};
DirectFieldAccessor dfa = new DirectFieldAccessor(p);
assertEquals(JTextField.class, dfa.getPropertyType("name"));
}
}