Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish: assertion arguments should be passed in the correct order,

Browse Source 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
This commit is contained in:
igor-suhorukov
2018-02-10 15:41:55 +03:00
committed by Juergen Hoeller
parent 39201adca4
commit 0ee505b73e
36 changed files with 142 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-beans/src/test/java/org/springframework/beans/BeanUtilsTests.java
View File

@@ -193,7 +193,7 @@ public class BeanUtilsTests {
source.setFlag2(true);
InvalidProperty target = new InvalidProperty();
BeanUtils.copyProperties(source, target);
assertEquals(target.getName(), "name");
assertEquals("name", target.getName());
assertTrue(target.getFlag1());
assertTrue(target.getFlag2());
}

2
spring-beans/src/test/java/org/springframework/beans/BeanWrapperGenericsTests.java
View File

@@ -518,7 +518,7 @@ public class BeanWrapperGenericsTests {
assertEquals("y", bw.getPropertyValue("data['x']"));
bw.setPropertyValue("data['message']", "it works!");
assertEquals(data.get("message"), "it works!");
assertEquals("it works!", data.get("message"));
}

4
spring-beans/src/test/java/org/springframework/beans/factory/ConcurrentBeanFactoryTests.java
View File

@@ -126,8 +126,8 @@ public class ConcurrentBeanFactoryTests {
ConcurrentBean b1 = (ConcurrentBean) factory.getBean("bean1");
ConcurrentBean b2 = (ConcurrentBean) factory.getBean("bean2");
assertEquals(b1.getDate(), DATE_1);
assertEquals(b2.getDate(), DATE_2);
assertEquals(DATE_1, b1.getDate());
assertEquals(DATE_2, b2.getDate());
}

36
spring-beans/src/test/java/org/springframework/beans/factory/xml/CollectionMergingTests.java
View File

@@ -55,9 +55,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithList");
List list = bean.getSomeList();
assertEquals("Incorrect size", 3, list.size());
assertEquals(list.get(0), "Rob Harrop");
assertEquals(list.get(1), "Rod Johnson");
assertEquals(list.get(2), "Juergen Hoeller");
assertEquals("Rob Harrop", list.get(0));
assertEquals("Rod Johnson", list.get(1));
assertEquals("Juergen Hoeller", list.get(2));
}
@Test
@@ -98,9 +98,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithMap");
Map map = bean.getSomeMap();
assertEquals("Incorrect size", 3, map.size());
assertEquals(map.get("Rob"), "Sally");
assertEquals(map.get("Rod"), "Kerry");
assertEquals(map.get("Juergen"), "Eva");
assertEquals("Sally", map.get("Rob"));
assertEquals("Kerry", map.get("Rod"));
assertEquals("Eva", map.get("Juergen"));
}
@Test
@@ -119,9 +119,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithProps");
Properties props = bean.getSomeProperties();
assertEquals("Incorrect size", 3, props.size());
assertEquals(props.getProperty("Rob"), "Sally");
assertEquals(props.getProperty("Rod"), "Kerry");
assertEquals(props.getProperty("Juergen"), "Eva");
assertEquals("Sally", props.getProperty("Rob"));
assertEquals("Kerry",props.getProperty("Rod"));
assertEquals("Eva", props.getProperty("Juergen"));
}
@Test
@@ -129,9 +129,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithListInConstructor");
List list = bean.getSomeList();
assertEquals("Incorrect size", 3, list.size());
assertEquals(list.get(0), "Rob Harrop");
assertEquals(list.get(1), "Rod Johnson");
assertEquals(list.get(2), "Juergen Hoeller");
assertEquals("Rob Harrop", list.get(0));
assertEquals("Rod Johnson", list.get(1));
assertEquals("Juergen Hoeller", list.get(2));
}
@Test
@@ -172,9 +172,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithMapInConstructor");
Map map = bean.getSomeMap();
assertEquals("Incorrect size", 3, map.size());
assertEquals(map.get("Rob"), "Sally");
assertEquals(map.get("Rod"), "Kerry");
assertEquals(map.get("Juergen"), "Eva");
assertEquals("Sally", map.get("Rob"));
assertEquals("Kerry", map.get("Rod"));
assertEquals("Eva", map.get("Juergen"));
}
@Test
@@ -193,9 +193,9 @@ public class CollectionMergingTests {
TestBean bean = (TestBean) this.beanFactory.getBean("childWithPropsInConstructor");
Properties props = bean.getSomeProperties();
assertEquals("Incorrect size", 3, props.size());
assertEquals(props.getProperty("Rob"), "Sally");
assertEquals(props.getProperty("Rod"), "Kerry");
assertEquals(props.getProperty("Juergen"), "Eva");
assertEquals("Sally", props.getProperty("Rob"));
assertEquals("Kerry", props.getProperty("Rod"));
assertEquals("Eva", props.getProperty("Juergen"));
}
}