Polish: assertion arguments should be passed in the correct order,

use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
This commit is contained in:
igor-suhorukov
2018-02-10 15:41:55 +03:00
committed by Juergen Hoeller
parent 39201adca4
commit 0ee505b73e
36 changed files with 142 additions and 142 deletions

View File

@@ -1064,12 +1064,12 @@ public abstract class AbstractAopProxyTests {
pc.addAdvisor(dp);
pc.setTarget(tb);
ITestBean it = (ITestBean) createProxy(pc);
assertEquals(dp.count, 0);
assertEquals(0, dp.count);
it.getAge();
assertEquals(dp.count, 1);
assertEquals(1, dp.count);
it.setAge(11);
assertEquals(it.getAge(), 11);
assertEquals(dp.count, 2);
assertEquals(11, it.getAge());
assertEquals(2, dp.count);
}
@Test
@@ -1083,16 +1083,16 @@ public abstract class AbstractAopProxyTests {
this.mockTargetSource.setTarget(tb);
pc.setTargetSource(mockTargetSource);
ITestBean it = (ITestBean) createProxy(pc);
assertEquals(dp.count, 0);
assertEquals(0, dp.count);
it.getAge();
// Statically vetoed
assertEquals(0, dp.count);
it.setAge(11);
assertEquals(it.getAge(), 11);
assertEquals(dp.count, 1);
assertEquals(11, it.getAge());
assertEquals(1, dp.count);
// Applies statically but not dynamically
it.setName("joe");
assertEquals(dp.count, 1);
assertEquals(1, dp.count);
}
@Test

View File

@@ -154,7 +154,7 @@ public class ConfigurationClassProcessingTests {
public void simplestPossibleConfig() {
BeanFactory factory = initBeanFactory(SimplestPossibleConfig.class);
String stringBean = factory.getBean("stringBean", String.class);
assertEquals(stringBean, "foo");
assertEquals("foo", stringBean);
}
@Test
@@ -163,7 +163,7 @@ public class ConfigurationClassProcessingTests {
assertEquals(Object.class, factory.getType("stringBean"));
assertFalse(factory.isTypeMatch("stringBean", String.class));
String stringBean = factory.getBean("stringBean", String.class);
assertEquals(stringBean, "foo");
assertEquals("foo", stringBean);
}
@Test

View File

@@ -55,7 +55,7 @@ public class RmiSupportTests {
assertTrue(factory.getObject() instanceof IRemoteBean);
IRemoteBean proxy = (IRemoteBean) factory.getObject();
proxy.setName("myName");
assertEquals(RemoteBean.name, "myName");
assertEquals("myName", RemoteBean.name);
assertEquals(1, factory.counter);
}
@@ -179,7 +179,7 @@ public class RmiSupportTests {
IBusinessBean proxy = (IBusinessBean) factory.getObject();
assertFalse(proxy instanceof IRemoteBean);
proxy.setName("myName");
assertEquals(RemoteBean.name, "myName");
assertEquals("myName", RemoteBean.name);
assertEquals(1, factory.counter);
}