Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish: assertion arguments should be passed in the correct order,

Browse Source 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
This commit is contained in:
igor-suhorukov
2018-02-10 15:41:55 +03:00
committed by Juergen Hoeller
parent 39201adca4
commit 0ee505b73e
36 changed files with 142 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java
View File

@@ -92,7 +92,7 @@ public class SpringHandlerInstantiatorTests {
public void autowiredDeserializer() throws IOException {
String json = "{\"username\":\"bob\"}";
User user = this.objectMapper.readValue(json, User.class);
assertEquals(user.getUsername(), "BOB");
assertEquals("BOB", user.getUsername());
}
@Test

4
spring-web/src/test/java/org/springframework/remoting/caucho/CauchoRemotingTests.java
View File

@@ -99,8 +99,8 @@ public class CauchoRemotingTests {
assertTrue(factory.getObject() instanceof ITestBean);
ITestBean bean = (ITestBean) factory.getObject();
assertEquals(proxyFactory.user, "test");
assertEquals(proxyFactory.password, "bean");
assertEquals("test", proxyFactory.user);
assertEquals("bean", proxyFactory.password);
assertTrue(proxyFactory.overloadEnabled);
exception.expect(RemoteAccessException.class);

2
spring-web/src/test/java/org/springframework/web/accept/MappingMediaTypeFileExtensionResolverTests.java
View File

@@ -62,7 +62,7 @@ public class MappingMediaTypeFileExtensionResolverTests {
MappingMediaTypeFileExtensionResolver resolver = new MappingMediaTypeFileExtensionResolver(mapping);
MediaType mediaType = resolver.lookupMediaType("JSON");
assertEquals(mediaType, MediaType.APPLICATION_JSON);
assertEquals(MediaType.APPLICATION_JSON, mediaType);
}
}

8
spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerTests.java
View File

@@ -66,7 +66,7 @@ public class WebAsyncManagerTests {
fail("Expected exception");
}
catch (IllegalStateException ex) {
assertEquals(ex.getMessage(), "AsyncWebRequest must not be null");
assertEquals("AsyncWebRequest must not be null", ex.getMessage());
}
try {
@@ -74,7 +74,7 @@ public class WebAsyncManagerTests {
fail("Expected exception");
}
catch (IllegalStateException ex) {
assertEquals(ex.getMessage(), "AsyncWebRequest must not be null");
assertEquals("AsyncWebRequest must not be null", ex.getMessage());
}
}
@@ -256,7 +256,7 @@ public class WebAsyncManagerTests {
fail("Expected exception");
}
catch (IllegalArgumentException ex) {
assertEquals(ex.getMessage(), "Callable must not be null");
assertEquals("Callable must not be null", ex.getMessage());
}
}
@@ -357,7 +357,7 @@ public class WebAsyncManagerTests {
fail("Expected exception");
}
catch (IllegalArgumentException ex) {
assertEquals(ex.getMessage(), "DeferredResult must not be null");
assertEquals("DeferredResult must not be null", ex.getMessage());
}
}

4
spring-web/src/test/java/org/springframework/web/jsf/DelegatingPhaseListenerTests.java
View File

@@ -51,7 +51,7 @@ public class DelegatingPhaseListenerTests {
TestListener target = new TestListener();
beanFactory.addBean("testListener", target);
assertEquals(delPhaseListener.getPhaseId(), PhaseId.ANY_PHASE);
assertEquals(PhaseId.ANY_PHASE, delPhaseListener.getPhaseId());
PhaseEvent event = new PhaseEvent(facesContext, PhaseId.INVOKE_APPLICATION, new MockLifecycle());
delPhaseListener.beforePhase(event);
@@ -68,7 +68,7 @@ public class DelegatingPhaseListenerTests {
beanFactory.addBean("testListener1", target1);
beanFactory.addBean("testListener2", target2);
assertEquals(delPhaseListener.getPhaseId(), PhaseId.ANY_PHASE);
assertEquals(PhaseId.ANY_PHASE, delPhaseListener.getPhaseId());
PhaseEvent event = new PhaseEvent(facesContext, PhaseId.INVOKE_APPLICATION, new MockLifecycle());
delPhaseListener.beforePhase(event);

2
spring-web/src/test/java/org/springframework/web/util/HtmlUtilsTests.java
View File

@@ -42,7 +42,7 @@ public class HtmlUtilsTests {
public void testHtmlUnescape() {
String escaped = ""This is a quote'";
String unescaped = HtmlUtils.htmlUnescape(escaped);
assertEquals(unescaped, "\"This is a quote'");
assertEquals("\"This is a quote'", unescaped);
}
@Test

4
spring-web/src/test/java/org/springframework/web/util/ServletContextPropertyUtilsTests.java
View File

@@ -31,7 +31,7 @@ public class ServletContextPropertyUtilsTests {
MockServletContext servletContext = new MockServletContext();
servletContext.setInitParameter("test.prop", "bar");
String resolved = ServletContextPropertyUtils.resolvePlaceholders("${test.prop:foo}", servletContext);
assertEquals(resolved, "bar");
assertEquals("bar", resolved);
}
@Test
@@ -40,7 +40,7 @@ public class ServletContextPropertyUtilsTests {
System.setProperty("test.prop", "bar");
try {
String resolved = ServletContextPropertyUtils.resolvePlaceholders("${test.prop:foo}", servletContext);
assertEquals(resolved, "bar");
assertEquals("bar", resolved);
}
finally {
System.clearProperty("test.prop");

8
spring-web/src/test/java/org/springframework/web/util/TagUtilsTests.java
View File

@@ -34,10 +34,10 @@ public class TagUtilsTests {
@Test
public void getScopeSunnyDay() {
assertEquals(TagUtils.SCOPE_PAGE, "page");
assertEquals(TagUtils.SCOPE_APPLICATION, "application");
assertEquals(TagUtils.SCOPE_SESSION, "session");
assertEquals(TagUtils.SCOPE_REQUEST, "request");
assertEquals("page", TagUtils.SCOPE_PAGE);
assertEquals("application", TagUtils.SCOPE_APPLICATION);
assertEquals("session", TagUtils.SCOPE_SESSION);
assertEquals("request", TagUtils.SCOPE_REQUEST);
assertEquals(PageContext.PAGE_SCOPE, TagUtils.getScope("page"));
assertEquals(PageContext.REQUEST_SCOPE, TagUtils.getScope("request"));