Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix client-library-url ignored in MVC namespace

Browse Source 
Prior to this commit, the `client-library-url` XML attribute was not
effective in the MVC namespace, leaving the default value configured:

```xml
<websocket:sockjs client-library-url="/js/sockjs.js" />
```

This commit fixes the sockjs namespace handler and makes sure that this
attribute is configured on the `SockJsService` Bean to be created.

Issue: SPR-12874
This commit is contained in:
Brian Clozel
2015-04-01 14:44:12 +02:00
parent 25f6001ad6
commit 100d75da26
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketNamespaceUtils.java
View File

@@ -137,6 +137,10 @@ class WebSocketNamespaceUtils {
if (!attrValue.isEmpty()) {
sockJsServiceDef.getPropertyValues().add("heartbeatTime", Long.valueOf(attrValue));
}
attrValue = sockJsElement.getAttribute("client-library-url");
if (!attrValue.isEmpty()) {
sockJsServiceDef.getPropertyValues().add("sockJsClientLibraryUrl", attrValue);
}
attrValue = sockJsElement.getAttribute("message-codec");
if (!attrValue.isEmpty()) {
sockJsServiceDef.getPropertyValues().add("messageCodec", new RuntimeBeanReference(attrValue));