Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix regression in JmsAccessor#setSessionAcknowledgeMode

Browse Source 
This commit partially reverts 3b8dd0a5, which introduced a strict
validation in JmsAccessor#setSessionAcknowledgeMode that prevents use
of vendor-specific acknowledge modes.

See gh-31328
This commit is contained in:
Vedran Pavic
2023-09-27 19:24:56 +02:00
committed by Stéphane Nicoll
parent ce9ca700f3
commit 11c2cde62e
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-jms/src/main/java/org/springframework/jms/support/JmsAccessor.java
View File

@@ -167,8 +167,6 @@ public abstract class JmsAccessor implements InitializingBean {
* @see jakarta.jms.Connection#createSession(boolean, int) * @see jakarta.jms.Connection#createSession(boolean, int)
*/ */
public void setSessionAcknowledgeMode(int sessionAcknowledgeMode) { public void setSessionAcknowledgeMode(int sessionAcknowledgeMode) {
Assert.isTrue(sessionConstants.containsValue(sessionAcknowledgeMode),
"Only values of acknowledge mode constants allowed");
this.sessionAcknowledgeMode = sessionAcknowledgeMode; this.sessionAcknowledgeMode = sessionAcknowledgeMode;
} }

5
spring-jms/src/test/java/org/springframework/jms/support/JmsAccessorTests.java
View File

@@ -98,8 +98,6 @@ class JmsAccessorTests {
@Test @Test
void setSessionAcknowledgeMode() { void setSessionAcknowledgeMode() {
assertThatIllegalArgumentException().isThrownBy(() -> accessor.setSessionAcknowledgeMode(999));
accessor.setSessionAcknowledgeMode(Session.AUTO_ACKNOWLEDGE); accessor.setSessionAcknowledgeMode(Session.AUTO_ACKNOWLEDGE);
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.AUTO_ACKNOWLEDGE); assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.AUTO_ACKNOWLEDGE);
@@ -111,6 +109,9 @@ class JmsAccessorTests {
accessor.setSessionAcknowledgeMode(Session.SESSION_TRANSACTED); accessor.setSessionAcknowledgeMode(Session.SESSION_TRANSACTED);
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.SESSION_TRANSACTED); assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.SESSION_TRANSACTED);
accessor.setSessionAcknowledgeMode(999);
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(999);
} }
@Test @Test