From 1278459ad536126a7c707e4b69a0a359f54bb556 Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Thu, 22 Feb 2018 15:12:51 +0100 Subject: [PATCH] ReactorHttpHandlerAdapter logs bad request at warn level only Issue: SPR-16524 --- .../http/server/reactive/ReactorHttpHandlerAdapter.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java index 85f488e5b4..b4c27f78b6 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java @@ -34,10 +34,10 @@ import org.springframework.util.Assert; * Adapt {@link HttpHandler} to the Reactor Netty channel handling function. * * @author Stephane Maldini + * @author Rossen Stoyanchev * @since 5.0 */ -public class ReactorHttpHandlerAdapter - implements BiFunction> { +public class ReactorHttpHandlerAdapter implements BiFunction> { private static final Log logger = LogFactory.getLog(ReactorHttpHandlerAdapter.class); @@ -53,7 +53,6 @@ public class ReactorHttpHandlerAdapter @Override public Mono apply(HttpServerRequest request, HttpServerResponse response) { - NettyDataBufferFactory bufferFactory = new NettyDataBufferFactory(response.alloc()); ServerHttpRequest adaptedRequest; ServerHttpResponse adaptedResponse; @@ -62,7 +61,9 @@ public class ReactorHttpHandlerAdapter adaptedResponse = new ReactorServerHttpResponse(response, bufferFactory); } catch (URISyntaxException ex) { - logger.error("Invalid URL " + ex.getMessage(), ex); + if (logger.isWarnEnabled()) { + logger.warn("Invalid URL for incoming request: " + ex.getMessage()); + } response.status(HttpResponseStatus.BAD_REQUEST); return Mono.empty(); }