Fix compiler warnings

This patch fixes several compiler warnings that do not point to code
problems. Two kinds of warnings are fixed. First in a lot of cases
@SuppressWarnings("unchecked") is used although there are no unchecked
casts happening. This seems to be a leftover from when the code base
was on Java 1.4, now that the code base was moved to Java 1.5 these are
no longer necessary. Secondly there some places where the raw types of
List and Class are used where there wildcard types (List<?> and
Class<?>) would work just as well without causing any raw type warnings.

These changes are beneficial particularly when working in Eclipse or
other IDEs because it reduces 'noise', helping to isolate actual
potential problems in the code.

The following changes have been made:

 - remove @SuppressWarnings where no longer needed

 - use wildcard types instead of raw types where possible
This commit is contained in:
Philippe Marschall
2012-02-11 20:32:37 +01:00
committed by Chris Beams
parent e68b563626
commit 13239a0c3d
11 changed files with 12 additions and 30 deletions

View File

@@ -168,7 +168,6 @@ public class JobDetailFactoryBean
}
@SuppressWarnings("unchecked")
public void afterPropertiesSet() {
if (this.name == null) {
this.name = this.beanName;
@@ -196,7 +195,7 @@ public class JobDetailFactoryBean
this.jobDetail = jdi;
*/
Class jobDetailClass;
Class<?> jobDetailClass;
try {
jobDetailClass = getClass().getClassLoader().loadClass("org.quartz.impl.JobDetailImpl");
}