Component scanning ignores attributes and meta-annotations on non-public annotations

Issue: SPR-11091

spring-context/src/test/java/example/scannable/CustomAnnotations.java

@@ -0,0 +1,34 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package example.scannable;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+public class CustomAnnotations {
+
+	@Retention(RetentionPolicy.RUNTIME)
+	private @interface PrivateAnnotation {
+		String value();
+	}
+
+	@Retention(RetentionPolicy.RUNTIME)
+	@PrivateAnnotation("special")
+	public @interface SpecialAnnotation {
+	}
+
+}

spring-context/src/test/java/example/scannable/CustomComponent.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2007 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -28,6 +28,7 @@ import java.lang.annotation.Target;
 @Target(ElementType.TYPE)
 @Retention(RetentionPolicy.RUNTIME)
 @Inherited
+@CustomAnnotations.SpecialAnnotation
 public @interface CustomComponent {
 
 }

spring-context/src/test/java/example/scannable/MessageBean.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@ package example.scannable;
  * @author Mark Fisher
  */
 @CustomComponent
+@CustomAnnotations.SpecialAnnotation
 public class MessageBean {
 
 	private String message;
@@ -32,6 +33,7 @@ public class MessageBean {
 		this.message = message;
 	}
 
+	@CustomAnnotations.SpecialAnnotation
 	public String getMessage() {
 		return this.message;
 	}

spring-core/src/main/java/org/springframework/core/type/classreading/AnnotationAttributesReadingVisitor.java

@@ -20,6 +20,7 @@ import java.lang.annotation.Annotation;
 import java.lang.reflect.Array;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.LinkedHashSet;
 import java.util.List;
@@ -28,6 +29,7 @@ import java.util.Set;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.asm.AnnotationVisitor;
 import org.springframework.asm.SpringAsmInfo;
 import org.springframework.asm.Type;
@@ -51,14 +53,12 @@ abstract class AbstractRecursiveAnnotationVisitor extends AnnotationVisitor {
 
 	protected final ClassLoader classLoader;
 
-
 	public AbstractRecursiveAnnotationVisitor(ClassLoader classLoader, AnnotationAttributes attributes) {
 		super(SpringAsmInfo.ASM_VERSION);
 		this.classLoader = classLoader;
 		this.attributes = attributes;
 	}
 
-
 	@Override
 	public void visit(String attributeName, Object attributeValue) {
 		this.attributes.put(attributeName, attributeValue);
@@ -114,14 +114,12 @@ final class RecursiveAnnotationArrayVisitor extends AbstractRecursiveAnnotationV
 
 	private final List<AnnotationAttributes> allNestedAttributes = new ArrayList<AnnotationAttributes>();
 
-
 	public RecursiveAnnotationArrayVisitor(
 			String attributeName, AnnotationAttributes attributes, ClassLoader classLoader) {
 		super(classLoader, attributes);
 		this.attributeName = attributeName;
 	}
 
-
 	@Override
 	public void visit(String attributeName, Object attributeValue) {
 		Object newValue = attributeValue;
@@ -170,24 +168,21 @@ class RecursiveAnnotationAttributesVisitor extends AbstractRecursiveAnnotationVi
 
 	private final String annotationType;
 
-
 	public RecursiveAnnotationAttributesVisitor(
 			String annotationType, AnnotationAttributes attributes, ClassLoader classLoader) {
 		super(classLoader, attributes);
 		this.annotationType = annotationType;
 	}
 
-
 	@Override
 	public final void visitEnd() {
 		try {
 			Class<?> annotationClass = this.classLoader.loadClass(this.annotationType);
-			this.doVisitEnd(annotationClass);
+			doVisitEnd(annotationClass);
 		}
 		catch (ClassNotFoundException ex) {
-			this.logger.debug("Failed to classload type while reading annotation " +
+			this.logger.debug("Failed to class-load type while reading annotation metadata. " +
-					"metadata. This is a non-fatal error, but certain annotation " +
+					"This is a non-fatal error, but certain annotation metadata may be unavailable.", ex);
-					"metadata may be unavailable.", ex);
 		}
 	}
 
@@ -196,6 +191,9 @@ class RecursiveAnnotationAttributesVisitor extends AbstractRecursiveAnnotationVi
 	}
 
 	private void registerDefaultValues(Class<?> annotationClass) {
+		// Only do further scanning for public annotations; we'd run into IllegalAccessExceptions
+		// otherwise, and don't want to mess with accessibility in a SecurityManager environment.
+		if (Modifier.isPublic(annotationClass.getModifiers())) {
 			// Check declared default values of attributes in the annotation type.
 			Method[] annotationAttributes = annotationClass.getMethods();
 			for (Method annotationAttribute : annotationAttributes) {
@@ -220,6 +218,7 @@ class RecursiveAnnotationAttributesVisitor extends AbstractRecursiveAnnotationVi
 			}
 		}
 	}
+}
 
 
 /**
@@ -267,19 +266,23 @@ final class AnnotationAttributesReadingVisitor extends RecursiveAnnotationAttrib
 		}
 		Set<String> metaAnnotationTypeNames = new LinkedHashSet<String>();
 		for (Annotation metaAnnotation : annotationClass.getAnnotations()) {
-			recusivelyCollectMetaAnnotations(metaAnnotationTypeNames, metaAnnotation);
+			recursivelyCollectMetaAnnotations(metaAnnotationTypeNames, metaAnnotation);
 		}
 		if (this.metaAnnotationMap != null) {
 			this.metaAnnotationMap.put(annotationClass.getName(), metaAnnotationTypeNames);
 		}
 	}
 
-	private void recusivelyCollectMetaAnnotations(Set<String> visited, Annotation annotation) {
+	private void recursivelyCollectMetaAnnotations(Set<String> visited, Annotation annotation) {
 		if (visited.add(annotation.annotationType().getName())) {
+			// Only do further scanning for public annotations; we'd run into IllegalAccessExceptions
+			// otherwise, and don't want to mess with accessibility in a SecurityManager environment.
+			if (Modifier.isPublic(annotation.annotationType().getModifiers())) {
 				this.attributesMap.add(annotation.annotationType().getName(),
 						AnnotationUtils.getAnnotationAttributes(annotation, true, true));
 				for (Annotation metaMetaAnnotation : annotation.annotationType().getAnnotations()) {
-				recusivelyCollectMetaAnnotations(visited, metaMetaAnnotation);
+					recursivelyCollectMetaAnnotations(visited, metaMetaAnnotation);
+				}
 			}
 		}
 	}