Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Parse correctly ContentDisposition header with semicolons

Browse Source 
Issue: SPR-16091
This commit is contained in:
Sebastien Deleuze
2017-10-23 22:59:25 +02:00
parent a3e62284ea
commit 1c256a112b
2 changed files with 57 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java
View File

@@ -55,6 +55,22 @@ public class ContentDispositionTests {
assertEquals(ContentDisposition.builder("form-data").filename("unquoted").build(), disposition);
}
@Test // SPR-16091
public void parseFilenameWithSemicolon() {
ContentDisposition disposition = ContentDisposition
.parse("attachment; filename=\"filename with ; semicolon.txt\"");
assertEquals(ContentDisposition.builder("attachment")
.filename("filename with ; semicolon.txt").build(), disposition);
}
@Test
public void parseAndIgnoreEmptyParts() {
ContentDisposition disposition = ContentDisposition
.parse("form-data; name=\"foo\";; ; filename=\"foo.txt\"; size=123");
assertEquals(ContentDisposition.builder("form-data")
.name("foo").filename("foo.txt").size(123L).build(), disposition);
}
@Test
public void parseEncodedFilename() {
ContentDisposition disposition = ContentDisposition