More precise mapping for WebSocket handshake requests

Closes gh-26565
This commit is contained in:
Rossen Stoyanchev
2021-02-19 11:49:44 +00:00
parent 8535193df3
commit 1dd7d53de0
5 changed files with 284 additions and 12 deletions

View File

@@ -0,0 +1,70 @@
/*
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.web.socket.server.support;
import java.util.Collections;
import org.junit.jupiter.api.Test;
import org.springframework.web.HttpRequestHandler;
import org.springframework.web.context.support.StaticWebApplicationContext;
import org.springframework.web.servlet.HandlerExecutionChain;
import org.springframework.web.socket.WebSocketHandler;
import org.springframework.web.testfixture.servlet.MockHttpServletRequest;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
/**
* Unit tests for {@link WebSocketHandlerMapping}.
*
* @author Rossen Stoyanchev
*/
public class WebSocketHandlerMappingTests {
@Test
void webSocketHandshakeMatch() throws Exception {
HttpRequestHandler handler = new WebSocketHttpRequestHandler(mock(WebSocketHandler.class));
WebSocketHandlerMapping mapping = new WebSocketHandlerMapping();
mapping.setUrlMap(Collections.singletonMap("/path", handler));
mapping.setApplicationContext(new StaticWebApplicationContext());
MockHttpServletRequest request = new MockHttpServletRequest("GET", "/path");
HandlerExecutionChain chain = mapping.getHandler(request);
assertThat(chain).isNotNull();
assertThat(chain.getHandler()).isSameAs(handler);
mapping.setWebSocketUpgradeMatch(true);
chain = mapping.getHandler(request);
assertThat(chain).isNull();
request.addHeader("Upgrade", "websocket");
chain = mapping.getHandler(request);
assertThat(chain).isNotNull();
assertThat(chain.getHandler()).isSameAs(handler);
request.setMethod("POST");
chain = mapping.getHandler(request);
assertThat(chain).isNull();
}
}