Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix incomplete assertions

Browse Source 
Closes gh-30209
This commit is contained in:
Johnny Lim
2023-03-28 11:45:51 +09:00
committed by Brian Clozel
parent 50d01ce405
commit 2184d4e80e
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-core/src/test/java/org/springframework/core/io/ClassPathResourceTests.java
View File

@@ -231,7 +231,7 @@ class ClassPathResourceTests {
void emptyFileReadable(@TempDir(cleanup = NEVER) File tempDir) throws IOException { void emptyFileReadable(@TempDir(cleanup = NEVER) File tempDir) throws IOException {
File file = new File(tempDir, "empty.txt"); File file = new File(tempDir, "empty.txt");
assertThat(file.createNewFile()).isTrue(); assertThat(file.createNewFile()).isTrue();
assertThat(file.isFile()); assertThat(file.isFile()).isTrue();
try (URLClassLoader fileClassLoader = new URLClassLoader(new URL[]{tempDir.toURI().toURL()})) { try (URLClassLoader fileClassLoader = new URLClassLoader(new URL[]{tempDir.toURI().toURL()})) {
Resource emptyFile = new ClassPathResource("empty.txt", fileClassLoader); Resource emptyFile = new ClassPathResource("empty.txt", fileClassLoader);
@@ -246,7 +246,7 @@ class ClassPathResourceTests {
zipOut.putNextEntry(new ZipEntry("empty2.txt")); zipOut.putNextEntry(new ZipEntry("empty2.txt"));
zipOut.closeEntry(); zipOut.closeEntry();
} }
assertThat(jarFile.isFile()); assertThat(jarFile.isFile()).isTrue();
try (URLClassLoader jarClassLoader = new URLClassLoader(new URL[]{jarFile.toURI().toURL()})) { try (URLClassLoader jarClassLoader = new URLClassLoader(new URL[]{jarFile.toURI().toURL()})) {
Resource emptyJarEntry = new ClassPathResource("empty2.txt", jarClassLoader); Resource emptyJarEntry = new ClassPathResource("empty2.txt", jarClassLoader);

2
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/DefaultStompSessionTests.java
View File

@@ -398,7 +398,7 @@ public class DefaultStompSessionTests {
@Test // gh-23358 @Test // gh-23358
public void sendByteArray() { public void sendByteArray() {
this.session.afterConnected(this.connection); this.session.afterConnected(this.connection);
assertThat(this.session.isConnected()); assertThat(this.session.isConnected()).isTrue();
String destination = "/topic/foo"; String destination = "/topic/foo";
String payload = "sample payload"; String payload = "sample payload";

4
spring-messaging/src/test/java/org/springframework/messaging/support/NativeMessageHeaderAccessorTests.java
View File

@@ -236,7 +236,7 @@ public class NativeMessageHeaderAccessorTests {
Message<?> target = MessageBuilder.createMessage(source.getPayload(), targetAccessor.getMessageHeaders()); Message<?> target = MessageBuilder.createMessage(source.getPayload(), targetAccessor.getMessageHeaders());
MessageHeaderAccessor accessor = MessageHeaderAccessor.getMutableAccessor(target); MessageHeaderAccessor accessor = MessageHeaderAccessor.getMutableAccessor(target);
assertThat(accessor.isMutable()); assertThat(accessor.isMutable()).isTrue();
((NativeMessageHeaderAccessor) accessor).addNativeHeader("foo", "baz"); ((NativeMessageHeaderAccessor) accessor).addNativeHeader("foo", "baz");
assertThat(((NativeMessageHeaderAccessor) accessor).getNativeHeader("foo")).containsExactly("bar", "baz"); assertThat(((NativeMessageHeaderAccessor) accessor).getNativeHeader("foo")).containsExactly("bar", "baz");
} }
@@ -253,7 +253,7 @@ public class NativeMessageHeaderAccessorTests {
Message<?> target = MessageBuilder.createMessage(source.getPayload(), targetAccessor.getMessageHeaders()); Message<?> target = MessageBuilder.createMessage(source.getPayload(), targetAccessor.getMessageHeaders());
MessageHeaderAccessor accessor = MessageHeaderAccessor.getMutableAccessor(target); MessageHeaderAccessor accessor = MessageHeaderAccessor.getMutableAccessor(target);
assertThat(accessor.isMutable()); assertThat(accessor.isMutable()).isTrue();
((NativeMessageHeaderAccessor) accessor).addNativeHeader("foo", "baz"); ((NativeMessageHeaderAccessor) accessor).addNativeHeader("foo", "baz");
assertThat(((NativeMessageHeaderAccessor) accessor).getNativeHeader("foo")).containsExactly("bar", "baz"); assertThat(((NativeMessageHeaderAccessor) accessor).getNativeHeader("foo")).containsExactly("bar", "baz");
} }