From 261124f497370e355e7cda98997e8a45c6c664fb Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Thu, 8 Sep 2022 13:18:05 +0200 Subject: [PATCH] Remove flaky executesHugeScriptInReasonableTime() tests These tests often fail on the CI server and do not provide any meaningful information when they fail, since only a proper benchmark would suffice. Furthermore, the test method was introduced 10 years ago to address deficiencies in JDK 7 which no longer exist. See gh-14415 --- .../init/AbstractDatabasePopulatorTests.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/AbstractDatabasePopulatorTests.java b/spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/AbstractDatabasePopulatorTests.java index ff8401f3e3..8c6c681455 100644 --- a/spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/AbstractDatabasePopulatorTests.java +++ b/spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/AbstractDatabasePopulatorTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2022 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,7 +20,6 @@ import java.sql.Connection; import java.sql.SQLException; import org.junit.jupiter.api.Test; -import org.junit.jupiter.api.Timeout; import org.springframework.jdbc.datasource.DataSourceUtils; import org.springframework.transaction.support.TransactionSynchronizationManager; @@ -175,17 +174,6 @@ abstract class AbstractDatabasePopulatorTests extends AbstractDatabaseInitializa verify(populator).populate(connection); } - /** - * See SPR-9781 - */ - @Test - @Timeout(1) - void executesHugeScriptInReasonableTime() throws SQLException { - databasePopulator.addScript(defaultSchema()); - databasePopulator.addScript(resource("db-test-data-huge.sql")); - DatabasePopulatorUtils.execute(databasePopulator, db); - } - private void assertTestDatabaseCreated() { assertTestDatabaseCreated("Keith"); }