Test for overriding singleton @Bean method with scoped proxy in configuration subclass
Issue: SPR-10744
This commit is contained in:
@@ -0,0 +1,129 @@
|
|||||||
|
/*
|
||||||
|
* Copyright 2002-2014 the original author or authors.
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.springframework.context.annotation.configuration;
|
||||||
|
|
||||||
|
import org.junit.Test;
|
||||||
|
|
||||||
|
import org.springframework.beans.factory.ObjectFactory;
|
||||||
|
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
|
||||||
|
import org.springframework.context.annotation.Bean;
|
||||||
|
import org.springframework.context.annotation.Configuration;
|
||||||
|
import org.springframework.context.annotation.Scope;
|
||||||
|
import org.springframework.context.annotation.ScopedProxyMode;
|
||||||
|
|
||||||
|
import static org.hamcrest.Matchers.*;
|
||||||
|
import static org.junit.Assert.*;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @author Phillip Webb
|
||||||
|
*/
|
||||||
|
public class Spr10744Tests {
|
||||||
|
|
||||||
|
private static int createCount = 0;
|
||||||
|
|
||||||
|
private static int scopeCount = 0;
|
||||||
|
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testSpr10744() throws Exception {
|
||||||
|
AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext();
|
||||||
|
MyTestScope scope = new MyTestScope();
|
||||||
|
context.getBeanFactory().registerScope("myTestScope", scope);
|
||||||
|
context.register(MyTestConfiguration.class);
|
||||||
|
context.refresh();
|
||||||
|
Foo bean1 = context.getBean("foo", Foo.class);
|
||||||
|
Foo bean2 = context.getBean("foo", Foo.class);
|
||||||
|
assertThat(bean1, sameInstance(bean2));
|
||||||
|
// Should have created a single instance for the proxy
|
||||||
|
assertThat(createCount, equalTo(0));
|
||||||
|
assertThat(scopeCount, equalTo(0));
|
||||||
|
|
||||||
|
// Proxy mode should create new scoped object on each method call
|
||||||
|
bean1.getMessage();
|
||||||
|
assertThat(createCount, equalTo(1));
|
||||||
|
assertThat(scopeCount, equalTo(1));
|
||||||
|
bean1.getMessage();
|
||||||
|
assertThat(createCount, equalTo(2));
|
||||||
|
assertThat(scopeCount, equalTo(2));
|
||||||
|
|
||||||
|
context.close();
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
private static class MyTestScope implements org.springframework.beans.factory.config.Scope {
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Object get(String name, ObjectFactory<?> objectFactory) {
|
||||||
|
scopeCount++;
|
||||||
|
return objectFactory.getObject();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Object remove(String name) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void registerDestructionCallback(String name, Runnable callback) {
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Object resolveContextualObject(String key) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getConversationId() {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
static class Foo {
|
||||||
|
|
||||||
|
public Foo() {
|
||||||
|
createCount++;
|
||||||
|
}
|
||||||
|
|
||||||
|
public String getMessage() {
|
||||||
|
return "Hello";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@Configuration
|
||||||
|
static class MyConfiguration {
|
||||||
|
|
||||||
|
@Bean
|
||||||
|
public Foo foo() {
|
||||||
|
return new Foo();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@Configuration
|
||||||
|
static class MyTestConfiguration extends MyConfiguration {
|
||||||
|
|
||||||
|
@Override
|
||||||
|
@Scope(value = "myTestScope", proxyMode = ScopedProxyMode.TARGET_CLASS)
|
||||||
|
@Bean
|
||||||
|
public Foo foo() {
|
||||||
|
return new Foo();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user