Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert polish on Bean Override support

Browse Source 
This commit revers the removal of the `private` keyword in the examples
of the reference documentation and the tests for consistency. While the
default visibility makes the example more concise, it could imply to the
reader that the field (or the factory method) cannot be private.

Also, there is no need to multiply anything returned from `Objects.hash`
as its very distinct on its own already.
This commit is contained in:
Stéphane Nicoll
2024-06-12 08:05:35 +02:00
parent dc2c8d6094
commit 2d48371c6d
5 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-test/src/main/java/org/springframework/test/context/bean/override/OverrideMetadata.java
View File

@@ -80,9 +80,9 @@ public abstract class OverrideMetadata {
* @return a list of {@code OverrideMetadata}
*/
public static List<OverrideMetadata> forTestClass(Class<?> testClass) {
List<OverrideMetadata> metadataList = new LinkedList<>();
ReflectionUtils.doWithFields(testClass, field -> parseField(field, testClass, metadataList));
return metadataList;
List<OverrideMetadata> metadata = new LinkedList<>();
ReflectionUtils.doWithFields(testClass, field -> parseField(field, testClass, metadata));
return metadata;
}
private static void parseField(Field field, Class<?> testClass, List<OverrideMetadata> metadataList) {
@@ -185,7 +185,7 @@ public abstract class OverrideMetadata {
public int hashCode() {
int hash = Objects.hash(getClass(), this.beanType.getType(), this.beanName, this.strategy);
return (this.beanName != null ? hash : hash +
31 * Objects.hash(this.field.getName(), Arrays.hashCode(this.field.getAnnotations())));
Objects.hash(this.field.getName(), Arrays.hashCode(this.field.getAnnotations())));
}
@Override