Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Log HTTP method in logging filters and revise log message format

Browse Source 
Closes gh-23567
This commit is contained in:
Napster
2019-09-14 02:30:43 +02:00
committed by Sam Brannen
parent a65fd34801
commit 33cee066e5
2 changed files with 189 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spring-web/src/main/java/org/springframework/web/filter/AbstractRequestLoggingFilter.java
View File

@@ -322,7 +322,8 @@ public abstract class AbstractRequestLoggingFilter extends OncePerRequestFilter
protected String createMessage(HttpServletRequest request, String prefix, String suffix) {
StringBuilder msg = new StringBuilder();
msg.append(prefix);
msg.append("uri=").append(request.getRequestURI());
msg.append(request.getMethod()).append(" ");
msg.append(request.getRequestURI());
if (isIncludeQueryString()) {
String queryString = request.getQueryString();
@@ -334,15 +335,15 @@ public abstract class AbstractRequestLoggingFilter extends OncePerRequestFilter
if (isIncludeClientInfo()) {
String client = request.getRemoteAddr();
if (StringUtils.hasLength(client)) {
msg.append(";client=").append(client);
msg.append(", client=").append(client);
}
HttpSession session = request.getSession(false);
if (session != null) {
msg.append(";session=").append(session.getId());
msg.append(", session=").append(session.getId());
}
String user = request.getRemoteUser();
if (user != null) {
msg.append(";user=").append(user);
msg.append(", user=").append(user);
}
}
@@ -357,13 +358,13 @@ public abstract class AbstractRequestLoggingFilter extends OncePerRequestFilter
}
}
}
msg.append(";headers=").append(headers);
msg.append(", headers=").append(headers);
}
if (isIncludePayload()) {
String payload = getMessagePayload(request);
if (payload != null) {
msg.append(";payload=").append(payload);
msg.append(", payload=").append(payload);
}
}