Polishing

spring-core/src/main/java/org/springframework/core/Constants.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -132,7 +132,7 @@ public class Constants {
 	/**
 	 * Parse the given String (upper or lower case accepted) and return
 	 * the appropriate value if it's the name of a constant field in the
-	 * class that we're analysing.
+	 * class that we're analyzing.
 	 * @param code the name of the field (never {@code null})
 	 * @return the Object value
 	 * @throws ConstantException if there's no such field

spring-core/src/main/java/org/springframework/core/Conventions.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -169,10 +169,7 @@ public final class Conventions {
 		Assert.notNull(method, "Method must not be null");
 
 		if (Object.class == resolvedType) {
-			if (value == null) {
-				throw new IllegalArgumentException(
-						"Cannot generate variable name for an Object return type with null value");
-			}
+			Assert.notNull(value, "Cannot generate variable name for an Object return type with null value");
 			return getVariableName(value);
 		}
 

spring-core/src/main/java/org/springframework/core/ReactiveTypeDescriptor.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -94,7 +94,7 @@ public final class ReactiveTypeDescriptor {
 
 	/**
 	 * Return an empty-value instance for the underlying reactive or async type.
-	 * Use of this type implies {@link #supportsEmpty()} is {@code true}.
+	 * <p>Use of this type implies {@link #supportsEmpty()} is {@code true}.
 	 */
 	public Object getEmptyValue() {
 		Assert.state(this.emptyValueSupplier != null, "Empty values not supported");

spring-core/src/main/java/org/springframework/core/io/buffer/DefaultDataBuffer.java

@@ -425,7 +425,7 @@ public class DefaultDataBuffer implements DataBuffer {
 	 * @see io.netty.buffer.AbstractByteBufAllocator#calculateNewCapacity(int, int)
 	 */
 	private int calculateCapacity(int neededCapacity) {
-		Assert.isTrue(neededCapacity >= 0, "'neededCapacity' must >= 0");
+		Assert.isTrue(neededCapacity >= 0, "'neededCapacity' must be >= 0");
 
 		if (neededCapacity == CAPACITY_THRESHOLD) {
 			return CAPACITY_THRESHOLD;

spring-core/src/main/java/org/springframework/core/io/buffer/Netty5DataBuffer.java

@@ -28,7 +28,6 @@ import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 import org.springframework.util.ObjectUtils;
 
-
 /**
  * Implementation of the {@code DataBuffer} interface that wraps a Netty 5
  * {@link Buffer}. Typically constructed with {@link Netty5DataBufferFactory}.
@@ -37,8 +36,7 @@ import org.springframework.util.ObjectUtils;
  * @author Arjen Poutsma
  * @since 6.0
  */
-public final class Netty5DataBuffer implements CloseableDataBuffer,
-		TouchableDataBuffer {
+public final class Netty5DataBuffer implements CloseableDataBuffer, TouchableDataBuffer {
 
 	private final Buffer buffer;
 
@@ -51,7 +49,7 @@ public final class Netty5DataBuffer implements CloseableDataBuffer,
 	 */
 	Netty5DataBuffer(Buffer buffer, Netty5DataBufferFactory dataBufferFactory) {
 		Assert.notNull(buffer, "Buffer must not be null");
-		Assert.notNull(dataBufferFactory, "NettyDataBufferFactory must not be null");
+		Assert.notNull(dataBufferFactory, "Netty5DataBufferFactory must not be null");
 		this.buffer = buffer;
 		this.dataBufferFactory = dataBufferFactory;
 	}
@@ -150,7 +148,7 @@ public final class Netty5DataBuffer implements CloseableDataBuffer,
 
 	@Override
 	public DataBuffer ensureWritable(int capacity) {
-		Assert.isTrue(capacity >= 0, "Capacity must be larger than 0");
+		Assert.isTrue(capacity >= 0, "Capacity must be >= 0");
 		this.buffer.ensureWritable(capacity);
 		return this;
 	}
@@ -328,6 +326,7 @@ public final class Netty5DataBuffer implements CloseableDataBuffer,
 	}
 
 
+	@Override
 	public boolean equals(@Nullable Object other) {
 		return (this == other || (other instanceof Netty5DataBuffer dataBuffer &&
 				this.buffer.equals(dataBuffer.buffer)));