Support @Scheduled fixedDelay/fixedRate on Publisher-returning methods

This commit adds support for `@Scheduled` annotation on reactive
methods and Kotlin suspending functions.

Reactive methods are methods that return a `Publisher` or a subclass
of `Publisher`. The `ReactiveAdapterRegistry` is used to support many
implementations, such as `Flux`, `Mono`, `Flow`, `Single`, etc.
Methods should not take any argument and published values will be
ignored, as they are already with synchronous support.

This is implemented in `ScheduledAnnotationReactiveSupport`, which
"converts" Publishers to `Runnable`. This strategy keeps track of
active Subscriptions in the `ScheduledAnnotationBeanPostProcessor`,
in order to cancel them all in case of shutdown.
The existing scheduling support for tasks is reused, aligning the
triggering behavior with the existing support: cron, fixedDelay and
fixedRate are all supported strategies.

If the `Publisher` errors, the exception is logged at warn level and
otherwise ignored. As a result new `Runnable` instances will be
created for each execution and scheduling will continue.
The only difference with synchronous support is that error signals
will not be thrown by those `Runnable` tasks and will not be made
available to the `org.springframework.util.ErrorHandler` contract.
This is due to the asynchronous and lazy nature of Publishers.

Closes gh-23533
Closes gh-28515
This commit is contained in:
Simon Baslé
2023-06-05 12:25:15 +02:00
committed by Brian Clozel
parent 53f891226e
commit 35052f2113
7 changed files with 877 additions and 4 deletions

View File

@@ -0,0 +1,155 @@
/*
* Copyright 2002-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.scheduling.annotation
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.Deferred
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.flowOf
import org.assertj.core.api.Assertions
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
import org.springframework.scheduling.annotation.ScheduledAnnotationReactiveSupport.getPublisherFor
import org.springframework.scheduling.annotation.ScheduledAnnotationReactiveSupport.isReactive
import org.springframework.util.ReflectionUtils
import reactor.core.publisher.Mono
import java.util.concurrent.atomic.AtomicInteger
import kotlin.coroutines.Continuation
class KotlinScheduledAnnotationReactiveSupportTests {
@Test
fun ensureReactor() {
assertThat(ScheduledAnnotationReactiveSupport.reactorPresent).isTrue
}
@Test
fun ensureKotlinCoroutineReactorBridge() {
assertThat(ScheduledAnnotationReactiveSupport.coroutinesReactorPresent).isTrue
}
@ParameterizedTest
@ValueSource(strings = ["suspending", "suspendingReturns"])
fun isReactiveSuspending(methodName: String) {
val method = ReflectionUtils.findMethod(SuspendingFunctions::class.java, methodName, Continuation::class.java)!!
assertThat(isReactive(method)).isTrue
}
@ParameterizedTest
@ValueSource(strings = ["flow", "deferred"])
fun isReactiveKotlinType(methodName: String) {
val method = ReflectionUtils.findMethod(SuspendingFunctions::class.java, methodName)!!
assertThat(isReactive(method)).isTrue
}
@Test
fun isNotReactive() {
val method = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "notSuspending")!!
assertThat(isReactive(method)).isFalse
}
internal class SuspendingFunctions {
suspend fun suspending() {
}
suspend fun suspendingReturns(): String = "suspended"
suspend fun withParam(param: String): String {
return param
}
suspend fun throwsIllegalState() {
throw IllegalStateException("expected")
}
var subscription = AtomicInteger()
suspend fun suspendingTracking() {
subscription.incrementAndGet()
}
fun notSuspending() { }
fun flow(): Flow<Void> {
return flowOf()
}
fun deferred(): Deferred<Void> {
return CompletableDeferred()
}
}
private var target: SuspendingFunctions? = null
@BeforeEach
fun init() {
target = SuspendingFunctions()
}
@Test
fun checkKotlinRuntimeIfNeeded() {
val suspendingMethod = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "suspending", Continuation::class.java)!!
val notSuspendingMethod = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "notSuspending")!!
assertThat(isReactive(suspendingMethod)).describedAs("suspending").isTrue()
assertThat(isReactive(notSuspendingMethod)).describedAs("not suspending").isFalse()
}
@Test
fun isReactiveRejectsWithParams() {
val m = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "withParam", String::class.java, Continuation::class.java)!!
//isReactive rejects with some context
Assertions.assertThatIllegalArgumentException().isThrownBy { isReactive(m) }
.withMessage("Kotlin suspending functions may only be annotated with @Scheduled if declared without arguments")
.withNoCause()
}
@Test
fun rejectNotSuspending() {
val m = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "notSuspending")
//static helper method
Assertions.assertThatIllegalArgumentException().isThrownBy { getPublisherFor(m!!, target!!) }
.withMessage("Cannot convert the @Scheduled reactive method return type to Publisher")
.withNoCause()
}
@Test
fun suspendingThrowIsTurnedToMonoError() {
val m = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "throwsIllegalState", Continuation::class.java)
val mono = Mono.from(getPublisherFor(m!!, target!!))
Assertions.assertThatIllegalStateException().isThrownBy { mono.block() }
.withMessage("expected")
.withNoCause()
}
@Test
fun turningSuspendingFunctionToMonoDoesntExecuteTheMethod() {
val m = ReflectionUtils.findMethod(SuspendingFunctions::class.java, "suspendingTracking", Continuation::class.java)
val mono = Mono.from(getPublisherFor(m!!, target!!))
assertThat(target!!.subscription).hasValue(0)
mono.block()
assertThat(target!!.subscription).describedAs("after subscription").hasValue(1)
}
}