Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow auto grow for entries w/o default constructor in SpEL

Browse Source 
Prior to this commit, The "auto grow" feature in SpEL expressions only
worked for element types with a default constructor. For example, auto
grow did not work for a list of BigDecimal elements.

This commit inserts a null value in the list when no default
constructor can be found for the element type.

Closes gh-25367
This commit is contained in:
Martin Knopf
2020-07-07 14:47:48 +02:00
committed by Sam Brannen
parent d2e1150c79
commit 35c0ae7b0c
3 changed files with 39 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spring-expression/src/test/java/org/springframework/expression/spel/IndexingTests.java
View File

@@ -20,6 +20,7 @@ import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
@@ -199,6 +200,27 @@ public class IndexingTests {
}
}
public List<BigDecimal> decimals;
@Test
public void autoGrowWithoutDefaultConstructor() {
this.decimals = new ArrayList<>();
SpelExpressionParser parser = new SpelExpressionParser(new SpelParserConfiguration(true, true));
parser.parseExpression("decimals[0]").setValue(this, "123.4");
assertThat(decimals.get(0)).isEqualTo(BigDecimal.valueOf(123.4));
}
@Test
public void indexIntoPropertyContainingNullList() {
this.decimals = new ArrayList<>();
this.decimals.add(null);
this.decimals.add(BigDecimal.ONE);
SpelExpressionParser parser = new SpelExpressionParser(new SpelParserConfiguration(true, true));
parser.parseExpression("decimals[0]").setValue(this, "9876.5");
assertThat(decimals.get(0)).isEqualTo(BigDecimal.valueOf(9876.5));
assertThat(decimals.get(1)).isEqualTo(BigDecimal.ONE);
}
@Test
public void indexIntoPropertyContainingList() {
List<Integer> property = new ArrayList<>();