Backported refinements and polishing
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2015 the original author or authors.
|
||||
* Copyright 2002-2016 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -46,6 +46,7 @@ public class SimpleMappingExceptionResolver extends AbstractHandlerExceptionReso
|
||||
/** The default name of the exception attribute: "exception". */
|
||||
public static final String DEFAULT_EXCEPTION_ATTRIBUTE = "exception";
|
||||
|
||||
|
||||
private Properties exceptionMappings;
|
||||
|
||||
private Class<?>[] excludedExceptions;
|
||||
@@ -108,7 +109,7 @@ public class SimpleMappingExceptionResolver extends AbstractHandlerExceptionReso
|
||||
public void setStatusCodes(Properties statusCodes) {
|
||||
for (Enumeration<?> enumeration = statusCodes.propertyNames(); enumeration.hasMoreElements();) {
|
||||
String viewName = (String) enumeration.nextElement();
|
||||
Integer statusCode = new Integer(statusCodes.getProperty(viewName));
|
||||
Integer statusCode = Integer.valueOf(statusCodes.getProperty(viewName));
|
||||
this.statusCodes.put(viewName, statusCode);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2015 the original author or authors.
|
||||
* Copyright 2002-2016 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -78,13 +78,11 @@ import org.springframework.web.servlet.ModelAndView;
|
||||
* @author Juergen Hoeller
|
||||
* @since 1.1.1
|
||||
* @see ServletForwardingController
|
||||
* @see org.springframework.orm.jpa.support.OpenEntityManagerInViewInterceptor
|
||||
* @see org.springframework.orm.jpa.support.OpenEntityManagerInViewFilter
|
||||
*/
|
||||
public class ServletWrappingController extends AbstractController
|
||||
implements BeanNameAware, InitializingBean, DisposableBean {
|
||||
|
||||
private Class<?> servletClass;
|
||||
private Class<? extends Servlet> servletClass;
|
||||
|
||||
private String servletName;
|
||||
|
||||
@@ -105,7 +103,7 @@ public class ServletWrappingController extends AbstractController
|
||||
* Needs to implement {@code javax.servlet.Servlet}.
|
||||
* @see javax.servlet.Servlet
|
||||
*/
|
||||
public void setServletClass(Class<?> servletClass) {
|
||||
public void setServletClass(Class<? extends Servlet> servletClass) {
|
||||
this.servletClass = servletClass;
|
||||
}
|
||||
|
||||
@@ -142,12 +140,12 @@ public class ServletWrappingController extends AbstractController
|
||||
}
|
||||
if (!Servlet.class.isAssignableFrom(this.servletClass)) {
|
||||
throw new IllegalArgumentException("servletClass [" + this.servletClass.getName() +
|
||||
"] needs to implement interface [javax.servlet.Servlet]");
|
||||
"] needs to implement interface [javax.servlet.Servlet]");
|
||||
}
|
||||
if (this.servletName == null) {
|
||||
this.servletName = this.beanName;
|
||||
}
|
||||
this.servletInstance = (Servlet) this.servletClass.newInstance();
|
||||
this.servletInstance = this.servletClass.newInstance();
|
||||
this.servletInstance.init(new DelegatingServletConfig());
|
||||
}
|
||||
|
||||
@@ -158,7 +156,7 @@ public class ServletWrappingController extends AbstractController
|
||||
*/
|
||||
@Override
|
||||
protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response)
|
||||
throws Exception {
|
||||
throws Exception {
|
||||
|
||||
this.servletInstance.service(request, response);
|
||||
return null;
|
||||
|
||||
@@ -625,7 +625,7 @@ public class MvcUriComponentsBuilder {
|
||||
try {
|
||||
proxy = proxyClass.newInstance();
|
||||
}
|
||||
catch (Exception ex) {
|
||||
catch (Throwable ex) {
|
||||
throw new IllegalStateException("Unable to instantiate controller proxy using Objenesis, " +
|
||||
"and regular controller instantiation via default constructor fails as well", ex);
|
||||
}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2012 the original author or authors.
|
||||
* Copyright 2002-2016 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -73,7 +73,7 @@ import org.springframework.web.util.WebUtils;
|
||||
*/
|
||||
public class XsltView extends AbstractUrlBasedView {
|
||||
|
||||
private Class<?> transformerFactoryClass;
|
||||
private Class<? extends TransformerFactory> transformerFactoryClass;
|
||||
|
||||
private String sourceKey;
|
||||
|
||||
@@ -97,7 +97,7 @@ public class XsltView extends AbstractUrlBasedView {
|
||||
* <p>The default constructor of the specified class will be called
|
||||
* to build the TransformerFactory for this view.
|
||||
*/
|
||||
public void setTransformerFactoryClass(Class<?> transformerFactoryClass) {
|
||||
public void setTransformerFactoryClass(Class<? extends TransformerFactory> transformerFactoryClass) {
|
||||
Assert.isAssignable(TransformerFactory.class, transformerFactoryClass);
|
||||
this.transformerFactoryClass = transformerFactoryClass;
|
||||
}
|
||||
@@ -195,10 +195,10 @@ public class XsltView extends AbstractUrlBasedView {
|
||||
* @see #setTransformerFactoryClass
|
||||
* @see #getTransformerFactory()
|
||||
*/
|
||||
protected TransformerFactory newTransformerFactory(Class<?> transformerFactoryClass) {
|
||||
protected TransformerFactory newTransformerFactory(Class<? extends TransformerFactory> transformerFactoryClass) {
|
||||
if (transformerFactoryClass != null) {
|
||||
try {
|
||||
return (TransformerFactory) transformerFactoryClass.newInstance();
|
||||
return transformerFactoryClass.newInstance();
|
||||
}
|
||||
catch (Exception ex) {
|
||||
throw new TransformerFactoryConfigurationError(ex, "Could not instantiate TransformerFactory");
|
||||
|
||||
Reference in New Issue
Block a user