Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use StringJoiner where possible to simplify String joining

Browse Source
This commit is contained in:
stsypanov
2019-04-04 16:54:31 +03:00
committed by Juergen Hoeller
parent 07e9f802f2
commit 383f18e214
5 changed files with 21 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-core/src/main/java/org/springframework/core/convert/support/CollectionToStringConverter.java
View File

@@ -19,6 +19,7 @@ package org.springframework.core.convert.support;
import java.util.Collection;
import java.util.Collections;
import java.util.Set;
import java.util.StringJoiner;
import org.springframework.core.convert.ConversionService;
import org.springframework.core.convert.TypeDescriptor;
@@ -64,18 +65,13 @@ final class CollectionToStringConverter implements ConditionalGenericConverter {
if (sourceCollection.isEmpty()) {
return "";
}
StringBuilder sb = new StringBuilder();
int i = 0;
StringJoiner sj = new StringJoiner(DELIMITER);
for (Object sourceElement : sourceCollection) {
if (i > 0) {
sb.append(DELIMITER);
}
Object targetElement = this.conversionService.convert(
sourceElement, sourceType.elementTypeDescriptor(sourceElement), targetType);
sb.append(targetElement);
i++;
sj.add(String.valueOf(targetElement));
}
return sb.toString();
return sj.toString();
}
}